From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750909AbeCHWe0 (ORCPT ); Thu, 8 Mar 2018 17:34:26 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:55434 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbeCHWeX (ORCPT ); Thu, 8 Mar 2018 17:34:23 -0500 Subject: Re: [Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0 CPUs too To: Joao Martins , linux-kernel@vger.kernel.org Cc: Juergen Gross , "Rafael J. Wysocki" , Robert Moore , linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, devel@acpica.org, Erik Schmauss , Len Brown References: <20180308105751.8176-1-joao.m.martins@oracle.com> From: Boris Ostrovsky Message-ID: <4f20689f-552f-b9eb-272d-0035ba2efdd6@oracle.com> Date: Thu, 8 Mar 2018 17:33:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180308105751.8176-1-joao.m.martins@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8826 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=791 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803080243 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2018 05:57 AM, Joao Martins wrote: > @@ -372,6 +376,15 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv) > > pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk); > > + /* It has P-state dependencies */ > + if (!acpi_processor_get_psd(handle, &acpi_psd[acpi_id])) { > + __set_bit(acpi_id, acpi_id_psd_present); > + > + pr_debug("ACPI CPU%u w/ PST:coord_type = %llu domain = %llu\n", > + acpi_id, acpi_psd[acpi_id].coord_type, > + acpi_psd[acpi_id].domain); > + } I should have noticed this earlier, but do you really need acpi_id_psd_present? Can you just go by acpi_psd[i] != NULL? Sorry for missing it in the first patch. -boris