From: Laura Abbott <labbott@redhat.com>
To: Qing Xia <saberlily.xia@hisilicon.com>,
sumit.semwal@linaro.org, gregkh@linuxfoundation.org,
arve@android.com, tkjos@android.com, maco@android.com
Cc: linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org,
daniel.liuyi@hisilicon.com, yudongbin@hisilicon.com,
kongfei@hisilicon.com, puck.chen@hisilicon.com
Subject: Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags
Date: Tue, 19 Feb 2019 13:18:49 -0800 [thread overview]
Message-ID: <4f28e830-fd2b-c24b-3ffe-e711bb3cf3d3@redhat.com> (raw)
In-Reply-To: <1549004386-38778-1-git-send-email-saberlily.xia@hisilicon.com>
On 1/31/19 10:59 PM, Qing Xia wrote:
> In the first loop, gfp_flags will be modified to high_order_gfp_flags,
> and there will be no chance to change back to low_order_gfp_flags.
>
> Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")
> Signed-off-by: Qing Xia <saberlily.xia@hisilicon.com>
> ---
> drivers/staging/android/ion/ion_system_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index 0383f75..20f2103 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -223,10 +223,10 @@ static void ion_system_heap_destroy_pools(struct ion_page_pool **pools)
> static int ion_system_heap_create_pools(struct ion_page_pool **pools)
> {
> int i;
> - gfp_t gfp_flags = low_order_gfp_flags;
>
> for (i = 0; i < NUM_ORDERS; i++) {
> struct ion_page_pool *pool;
> + gfp_t gfp_flags = low_order_gfp_flags;
>
> if (orders[i] > 4)
> gfp_flags = high_order_gfp_flags;
>
Acked-by: Laura Abbott <labbott@redhat.com>
prev parent reply other threads:[~2019-02-19 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 6:59 [PATCH] staging: android: ion: fix sys heap pool's gfp_flags Qing Xia
2019-02-01 7:55 ` Chen Feng
2019-02-01 8:15 ` Dan Carpenter
2019-02-01 8:30 ` Xiaqing (A)
2019-02-19 21:18 ` Laura Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f28e830-fd2b-c24b-3ffe-e711bb3cf3d3@redhat.com \
--to=labbott@redhat.com \
--cc=arve@android.com \
--cc=daniel.liuyi@hisilicon.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kongfei@hisilicon.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=puck.chen@hisilicon.com \
--cc=saberlily.xia@hisilicon.com \
--cc=sumit.semwal@linaro.org \
--cc=tkjos@android.com \
--cc=yudongbin@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).