From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9362C4320E for ; Tue, 10 Aug 2021 18:17:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CBEC60527 for ; Tue, 10 Aug 2021 18:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235001AbhHJSRc (ORCPT ); Tue, 10 Aug 2021 14:17:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238811AbhHJSO7 (ORCPT ); Tue, 10 Aug 2021 14:14:59 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C67AC03E585 for ; Tue, 10 Aug 2021 10:46:58 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so23011oth.7 for ; Tue, 10 Aug 2021 10:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JNGqukZNLlv0aFWFy8HqZUMwbBzjAv62MTk5xyepWJw=; b=JfO53THyZ/pY2Xgb1vnPJRiXpCwHfgtTuAcYvNL5SGoveEsmVu2JWOCg2g3iO1AZtX YKuH+MlMF8XZayefBH1H5H4Eu2wbfzZhlXPFXA2PIRR4YWugzdysKg4p0EW5t6L8VENH Qci8mcQbZLW9n3WVkF8zuYA02j6t97zQqxmdI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JNGqukZNLlv0aFWFy8HqZUMwbBzjAv62MTk5xyepWJw=; b=GRQyZYIxMYot4JI3lA/qCNDWPMeLjDQ+ZHIg1PGhnaAmXB0f0TPlQDESTEkoCh2gBh AiSQbryFSpofxyvIhBJUnKVxbqSCRHTIqGf03LNbUjColMUoYd5NZhB4HaR3NO7zntRz cmuvod6/joirgqQc/b1VIJpy1/FFtWXWg41wyJ4lbYU98jXZTHFNenUm16ESdtjmP4Ll S4jApZ0iSJ36Anscyk6BFzsRvA6MrI/dyksclUPtym91SJiXhuhkfL1bGowOcEdwJGz/ 43MU0+YAE78x/XRviv7zX/j3tO48teYT+l3t1bswn7Wi0Oz0WDnueOa79PoinCuwK4GD Wvxw== X-Gm-Message-State: AOAM5311rHUeCYL2xfLQ4VuoDvBTHpx8T6npjfNFhROWntLA+betIXW6 2/Wa/Y7vS0aZkgIijNNIUJ7Ayw== X-Google-Smtp-Source: ABdhPJy4obKBBysTjZZbvUO3M5drqw9Q+yzknQFK4vObi5m9f4ZVdhjK1X/c/sZE3MwQ+PxfPSrLCw== X-Received: by 2002:a05:6830:16cb:: with SMTP id l11mr21199314otr.209.1628617617843; Tue, 10 Aug 2021 10:46:57 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id y5sm2778886ots.56.2021.08.10.10.46.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 10:46:57 -0700 (PDT) Subject: Re: [PATCH v2] vhci_hcd: USB port can get stuck in the disabled state To: Michael Cc: valentina.manea.m@gmail.com, shuah@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20210721235526.10588-1-msbroadf@gmail.com> <7b02cb66-d672-ae95-01ea-c6015725e1ac@linuxfoundation.org> <976d34c0-d603-1f16-edbd-ad6c8881ad4e@linuxfoundation.org> <5165bd84-11af-35dd-8a9b-11c7f219fb88@linuxfoundation.org> From: Shuah Khan Message-ID: <4f345afe-61d5-66b3-3252-562988c8926f@linuxfoundation.org> Date: Tue, 10 Aug 2021 11:46:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/2/21 7:00 PM, Michael wrote: > On Tue, 3 Aug 2021 at 09:14, Shuah Khan wrote: >> >> On 7/30/21 5:52 PM, Michael wrote: >>> Yes i think just adding the VDEV_ST_USED check in addition to the >>> VDEV_ST_NOT_ASSIGNED state is fine and would fix the issue. >>> >> >> Can you please confirm if this works? >> >>> After many years of writing virtualhere (a similar system to usb/ip >>> but cross-platform and different non-kernel way of doing it server >>> side) I've seen many drivers that issue reset at any time. Loading >>> firmware is usually the reason. Also sometimes switching >>> configurations requires a reset also, for example some gaming wheels >>> do this. I don't think you should make this VDEV_ST_USED check >>> specific to Wifi devices, as a lot of devices don't follow too closely >>> to the USB protocol to begin with from my experience. They primarily >>> base their USB interactions assuming the windows platform and its >>> quirks. >>> >> >> When sending responses to Linux kernel mailing lists, please use bottom post. >> This check will be used for all drivers. We don't add checks for specific cases >> in the code. >> >> thanks, >> -- Shuah >> > > Yes it works with that change. > Would you like to send me a patch for this? thanks, -- Shuah