From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
tglx@linutronix.de, mingo@kernel.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, bsingharora@gmail.com, maz@kernel.org
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
riel@surriel.com, hannes@cmpxchg.org
Subject: Re: [PATCH 4/6] kvm: Select SCHED_INFO instead of TASK_DELAY_ACCT
Date: Wed, 5 May 2021 13:37:12 +0200 [thread overview]
Message-ID: <4f35124c-1127-2629-2e00-800bc965e9f1@redhat.com> (raw)
In-Reply-To: <20210505111525.187225172@infradead.org>
On 05/05/21 12:59, Peter Zijlstra wrote:
> AFAICT KVM only relies on SCHED_INFO. Nothing uses the p->delays data
> that belongs to TASK_DELAY_ACCT.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Right, SCHED_INFO didn't exist at the time (it was introduced in 2015,
while KVM started using run_delay in 2011). I'm not sure if it could
have used SCHEDSTATS instead.
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
> ---
> arch/arm64/kvm/Kconfig | 5 +----
> arch/x86/kvm/Kconfig | 5 +----
> 2 files changed, 2 insertions(+), 8 deletions(-)
>
> --- a/arch/arm64/kvm/Kconfig
> +++ b/arch/arm64/kvm/Kconfig
> @@ -20,8 +20,6 @@ if VIRTUALIZATION
> menuconfig KVM
> bool "Kernel-based Virtual Machine (KVM) support"
> depends on OF
> - # for TASKSTATS/TASK_DELAY_ACCT:
> - depends on NET && MULTIUSER
> select MMU_NOTIFIER
> select PREEMPT_NOTIFIERS
> select HAVE_KVM_CPU_RELAX_INTERCEPT
> @@ -38,8 +36,7 @@ menuconfig KVM
> select IRQ_BYPASS_MANAGER
> select HAVE_KVM_IRQ_BYPASS
> select HAVE_KVM_VCPU_RUN_PID_CHANGE
> - select TASKSTATS
> - select TASK_DELAY_ACCT
> + select SCHED_INFO
> help
> Support hosting virtualized guest machines.
>
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -22,8 +22,6 @@ config KVM
> tristate "Kernel-based Virtual Machine (KVM) support"
> depends on HAVE_KVM
> depends on HIGH_RES_TIMERS
> - # for TASKSTATS/TASK_DELAY_ACCT:
> - depends on NET && MULTIUSER
> depends on X86_LOCAL_APIC
> select PREEMPT_NOTIFIERS
> select MMU_NOTIFIER
> @@ -36,8 +34,7 @@ config KVM
> select KVM_ASYNC_PF
> select USER_RETURN_NOTIFIER
> select KVM_MMIO
> - select TASKSTATS
> - select TASK_DELAY_ACCT
> + select SCHED_INFO
> select PERF_EVENTS
> select HAVE_KVM_MSI
> select HAVE_KVM_CPU_RELAX_INTERCEPT
>
>
next prev parent reply other threads:[~2021-05-05 11:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 10:59 [PATCH 0/6] sched,delayacct: Some cleanups Peter Zijlstra
2021-05-05 10:59 ` [PATCH 1/6] delayacct: Use sched_clock() Peter Zijlstra
2021-05-05 14:40 ` Rik van Riel
2021-05-06 13:59 ` Johannes Weiner
2021-05-06 14:17 ` Peter Zijlstra
2021-05-06 15:17 ` Johannes Weiner
2021-05-07 12:40 ` Balbir Singh
2021-05-12 10:28 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2021-05-12 10:43 ` [PATCH 1/6] " Mel Gorman
2021-05-05 10:59 ` [PATCH 2/6] sched: Rename sched_info_{queued,dequeued} Peter Zijlstra
2021-05-05 14:39 ` Rik van Riel
2021-05-06 13:59 ` Johannes Weiner
2021-05-10 8:45 ` Balbir Singh
2021-05-12 10:28 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2021-05-12 10:49 ` [PATCH 2/6] " Mel Gorman
2021-05-05 10:59 ` [PATCH 3/6] sched: Simplify sched_info_on() Peter Zijlstra
2021-05-06 14:03 ` Johannes Weiner
2021-05-12 10:28 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2021-05-12 11:10 ` [PATCH 3/6] " Mel Gorman
2021-05-12 11:32 ` Peter Zijlstra
2021-05-12 12:51 ` Mel Gorman
2021-05-05 10:59 ` [PATCH 4/6] kvm: Select SCHED_INFO instead of TASK_DELAY_ACCT Peter Zijlstra
2021-05-05 11:37 ` Paolo Bonzini [this message]
2021-05-06 14:38 ` Marc Zyngier
2021-05-07 12:42 ` Balbir Singh
2021-05-12 10:28 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2021-05-12 11:11 ` [PATCH 4/6] " Mel Gorman
2021-05-05 10:59 ` [PATCH 5/6] delayacct: Add static_branch in scheduler hooks Peter Zijlstra
2021-05-06 14:05 ` Johannes Weiner
2021-05-10 8:42 ` Balbir Singh
2021-05-12 10:28 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2021-05-12 11:13 ` [PATCH 5/6] " Mel Gorman
2021-05-05 10:59 ` [PATCH 6/6] [RFC] delayacct: Default disabled Peter Zijlstra
2021-05-12 10:28 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2021-05-12 11:35 ` [PATCH 6/6] [RFC] " Mel Gorman
2021-05-05 22:29 ` [PATCH 0/6] sched,delayacct: Some cleanups Balbir Singh
2021-05-06 9:13 ` Peter Zijlstra
2021-05-07 12:38 ` Balbir Singh
2021-05-12 11:34 ` Mel Gorman
2021-05-12 11:38 ` Peter Zijlstra
2021-05-12 12:23 ` Paul Wise
2021-05-12 13:00 ` Mel Gorman
2021-05-13 1:29 ` Paul Wise
2021-06-25 0:50 ` Paul Wise
2021-05-07 9:05 ` Thomas Gleixner
2021-05-10 7:08 ` Ingo Molnar
2021-05-10 12:05 ` [PATCH 7/6] delayacct: Add sysctl to enable at runtime Peter Zijlstra
2021-05-10 12:06 ` Peter Zijlstra
2021-05-12 10:28 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2021-05-12 11:40 ` [PATCH 7/6] " Mel Gorman
2021-05-19 8:09 ` [tip: sched/core] delayacct: Document task_delayacct sysctl tip-bot2 for Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f35124c-1127-2629-2e00-800bc965e9f1@redhat.com \
--to=pbonzini@redhat.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=bsingharora@gmail.com \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).