From: Doug Berger <opendmb@gmail.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] Revert "net: bcmgenet: use RGMII loopback for MAC reset"
Date: Tue, 17 Mar 2020 12:43:09 -0700 [thread overview]
Message-ID: <4f4a7695-0c6c-c5e8-84b2-602d0ee4fd29@gmail.com> (raw)
In-Reply-To: <de2ef417-ddf0-516f-4b11-ce834764497c@broadcom.com>
On 3/16/2020 7:21 PM, Florian Fainelli wrote:
>
>
> On 3/16/2020 2:44 PM, Doug Berger wrote:
>> This reverts commit 3a55402c93877d291b0a612d25edb03d1b4b93ac.
>>
>> This is not a good solution when connecting to an external switch
>> that may not support the isolation of the TXC signal resulting in
>> output driver contention on the pin.
>>
>> A different solution is necessary.
>>
>> Signed-off-by: Doug Berger <opendmb@gmail.com>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Did you want this to be tagged with:
>
> Fixes: 3a55402c9387 ("net: bcmgenet: use RGMII loopback for MAC reset")
>
> so as to make it more explicit how the two commits relate to each other?
I wasn't sure how best to tag this commit.
It seems odd to indicate that the reversion of a commit fixes the commit
that is reverted, but maybe that is the best way. It is more accurate to
say that the reversion of the commit reintroduces the problem that it
was intended to address, and therefore doesn't fix anything but rather
trades one problem for another.
It is clearer that the second commit fixes the original issue and so I
tagged it accordingly, but it is far less clear how a reversion like
this should be tagged.
If you think it is clearer to tag this as you describe I have no objection.
>
> Thanks!
> --
> Florian
>
Thank you for taking a look at this and for the feedback,
Doug
next prev parent reply other threads:[~2020-03-17 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 21:44 [PATCH net 0/2] net: bcmgenet: revisit MAC reset Doug Berger
2020-03-16 21:44 ` [PATCH net 1/2] Revert "net: bcmgenet: use RGMII loopback for MAC reset" Doug Berger
2020-03-17 2:21 ` Florian Fainelli
2020-03-17 19:43 ` Doug Berger [this message]
2020-03-16 21:44 ` [PATCH net 2/2] net: bcmgenet: keep MAC in reset until PHY is up Doug Berger
2020-03-17 2:22 ` Florian Fainelli
2020-03-18 4:02 ` [PATCH net 0/2] net: bcmgenet: revisit MAC reset David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f4a7695-0c6c-c5e8-84b2-602d0ee4fd29@gmail.com \
--to=opendmb@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).