From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, aarcange@redhat.com
Subject: Re: [PATCH net-next V4 5/5] vhost: access vq metadata through kernel virtual address
Date: Fri, 25 Jan 2019 17:24:16 +0800 [thread overview]
Message-ID: <4f4da5d5-0493-9da4-5ede-e344535bbb65@redhat.com> (raw)
In-Reply-To: <20190124214402-mutt-send-email-mst@kernel.org>
On 2019/1/25 上午11:03, Michael S. Tsirkin wrote:
>> +/* Suppress the vma that needs writeback since we can not track dirty
>> + * pages now.
>> + */
>> +static bool vma_can_vmap(struct vm_area_struct *vma)
>> +{
>> + return vma_is_anonymous(vma) || is_vm_hugetlb_page(vma) ||
>> + vma_is_shmem(vma);
>> +}
>> +
> IIUC a second but anonymous memory needs writeback too, just to swap.
> I'm not an MM person so I might be off.
Right, my fault, I mean the vma that needs dirty page tracking.
Thanks
next prev parent reply other threads:[~2019-01-25 9:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 9:55 [PATCH net-next V4 0/5] vhost: accelerate metadata access through vmap() Jason Wang
2019-01-23 9:55 ` [PATCH net-next V4 1/5] vhost: generalize adding used elem Jason Wang
2019-01-23 9:55 ` [PATCH net-next V4 2/5] vhost: fine grain userspace memory accessors Jason Wang
2019-01-23 9:55 ` [PATCH net-next V4 3/5] vhost: rename vq_iotlb_prefetch() to vq_meta_prefetch() Jason Wang
2019-01-23 9:55 ` [PATCH net-next V4 4/5] vhost: introduce helpers to get the size of metadata area Jason Wang
2019-01-23 9:55 ` [PATCH net-next V4 5/5] vhost: access vq metadata through kernel virtual address Jason Wang
2019-01-23 14:08 ` Michael S. Tsirkin
2019-01-24 4:07 ` Jason Wang
2019-01-24 4:11 ` Jason Wang
2019-01-24 4:53 ` Michael S. Tsirkin
2019-01-25 2:33 ` Jason Wang
2019-01-24 4:51 ` Michael S. Tsirkin
2019-01-25 3:00 ` Michael S. Tsirkin
2019-01-25 9:16 ` Jason Wang
2019-01-25 3:03 ` Michael S. Tsirkin
2019-01-25 9:21 ` Jason Wang
2019-01-25 9:24 ` Jason Wang [this message]
2019-01-23 13:58 ` [PATCH net-next V4 0/5] vhost: accelerate metadata access through vmap() Michael S. Tsirkin
2019-01-23 17:24 ` David Miller
2019-01-26 22:37 ` David Miller
2019-01-27 0:31 ` Michael S. Tsirkin
2019-01-29 2:34 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f4da5d5-0493-9da4-5ede-e344535bbb65@redhat.com \
--to=jasowang@redhat.com \
--cc=aarcange@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).