From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D1BC43460 for ; Mon, 19 Apr 2021 13:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2227A60FDB for ; Mon, 19 Apr 2021 13:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242193AbhDSNmE (ORCPT ); Mon, 19 Apr 2021 09:42:04 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:28307 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241320AbhDSNid (ORCPT ); Mon, 19 Apr 2021 09:38:33 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4FP7DQ0MNQz9txvF; Mon, 19 Apr 2021 15:37:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id tq4_mdvpTVt5; Mon, 19 Apr 2021 15:37:57 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FP7DP5hbsz9txvC; Mon, 19 Apr 2021 15:37:57 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DD5338B7BD; Mon, 19 Apr 2021 15:38:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id BdXw8b78KlDs; Mon, 19 Apr 2021 15:38:02 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 48A138B7B4; Mon, 19 Apr 2021 15:38:02 +0200 (CEST) Subject: Re: [PATCH 2/2] powerpc: add ALTIVEC support to lib/ when PPC_FPU not set To: Segher Boessenkool , Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Michael Ellerman , linuxppc-dev@lists.ozlabs.org References: <20210418201726.32130-1-rdunlap@infradead.org> <20210418201726.32130-2-rdunlap@infradead.org> <20210419133209.GR26583@gate.crashing.org> From: Christophe Leroy Message-ID: <4f5aea37-f638-3fde-0680-ec456ad91141@csgroup.eu> Date: Mon, 19 Apr 2021 15:38:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210419133209.GR26583@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 19/04/2021 à 15:32, Segher Boessenkool a écrit : > Hi! > > On Sun, Apr 18, 2021 at 01:17:26PM -0700, Randy Dunlap wrote: >> Add ldstfp.o to the Makefile for CONFIG_ALTIVEC and add >> externs for get_vr() and put_vr() in lib/sstep.c to fix the >> build errors. > >> obj-$(CONFIG_PPC_FPU) += ldstfp.o >> +obj-$(CONFIG_ALTIVEC) += ldstfp.o > > It is probably a good idea to split ldstfp.S into two, one for each of > the two configuration options? > Or we can build it all the time and #ifdef the FPU part. Because it contains FPU, ALTIVEC and VSX stuff. Christophe