From: Josef Bacik <josef@toxicpanda.com>
To: Sun Ke <sunke32@huawei.com>, axboe@kernel.dk, Markus.Elfring@web.de
Cc: linux-block@vger.kernel.org, nbd@other.debian.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/2] fix a NULL pointer bug and simplify the code
Date: Thu, 18 Feb 2021 15:39:41 -0500 [thread overview]
Message-ID: <4f9d9983-2409-301d-73da-94f0f58c8782@toxicpanda.com> (raw)
In-Reply-To: <20210218122620.228375-1-sunke32@huawei.com>
On 2/18/21 7:26 AM, Sun Ke wrote:
> fix a NULL pointer bug and simplify the code
>
> v6: Just add if (nbd->recv_workq) to nbd_disconnect_and_put().
> v5: Adjust the title and add “Suggested-by”.
> v4: Share exception handling code for if branches and
> move put_nbd adjustment to a separate patch.
> v3: Do not use unlock and add put_nbd.
> v2: Use jump target unlock.
>
> Sun Ke (2):
> nbd: Fix NULL pointer in flush_workqueue
> nbd: share nbd_put and return by goto put_nbd
>
> drivers/block/nbd.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
You can add
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
to both of these, thanks,
Josef
next prev parent reply other threads:[~2021-02-18 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 12:26 [PATCH v6 0/2] fix a NULL pointer bug and simplify the code Sun Ke
2021-02-18 12:26 ` [PATCH v6 1/2] nbd: Fix NULL pointer in flush_workqueue Sun Ke
2021-02-18 12:26 ` [PATCH v6 2/2] nbd: share nbd_put and return by goto put_nbd Sun Ke
2021-02-18 20:39 ` Josef Bacik [this message]
2021-02-19 1:07 ` [PATCH v6 0/2] fix a NULL pointer bug and simplify the code Jens Axboe
[not found] ` <aa80f848-c895-4478-f582-10a57a1166c3@huawei.com>
2021-05-11 13:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f9d9983-2409-301d-73da-94f0f58c8782@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=Markus.Elfring@web.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=sunke32@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).