From: Jonathan Cameron <jic23@kernel.org>
To: Arushi Singhal <arushisinghal19971997@gmail.com>, lars@metafoo.de
Cc: Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [RFC] staging: iio: ad7759: Replace mlock with driver private buf_lock
Date: Wed, 29 Mar 2017 22:16:36 +0100 [thread overview]
Message-ID: <4fd5df27-288b-f544-8860-4516ef52888f@kernel.org> (raw)
In-Reply-To: <20170328173721.GA12157@arushi-HP-Pavilion-Notebook>
On 28/03/17 18:37, Arushi Singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware state
> changes. Replace it with a buf_lock in the devices global data.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
Rule 1 of an RFC. Explain why it is an RFC rather than simply a
patch. What needs comment here in particular?
One thing that needs doing is a documentation update to reflect
the additional elements buf_lock is now protecting.
I think the use is sensible and can't otherwise see any issue with
this patch.
Thanks,
Jonathan
> ---
> drivers/staging/iio/meter/ade7759.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c
> index 0b65f1847510..514a4f6bb8f9 100644
> --- a/drivers/staging/iio/meter/ade7759.c
> +++ b/drivers/staging/iio/meter/ade7759.c
> @@ -429,7 +429,7 @@ static ssize_t ade7759_write_frequency(struct device *dev,
> if (!val)
> return -EINVAL;
>
> - mutex_lock(&indio_dev->mlock);
> + mutex_lock(&st->buf_lock);
>
> t = 27900 / val;
> if (t > 0)
> @@ -447,10 +447,13 @@ static ssize_t ade7759_write_frequency(struct device *dev,
> reg &= ~(3 << 13);
> reg |= t << 13;
>
> - ret = ade7759_spi_write_reg_16(dev, ADE7759_MODE, reg);
> + st->tx[0] = ADE7754_WRITE_REG(ADE7754_WAVMODE);
> + st->tx[1] = reg;
> +
> + ret = spi_write(st->us, st->tx, 2);
>
> out:
> - mutex_unlock(&indio_dev->mlock);
> + mutex_unlock(&st->buf_lock);
>
> return ret ? ret : len;
> }
>
prev parent reply other threads:[~2017-03-29 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 17:37 [RFC] staging: iio: ad7759: Replace mlock with driver private buf_lock Arushi Singhal
2017-03-29 21:16 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fd5df27-288b-f544-8860-4516ef52888f@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).