Re: [PATCH v4 0/8] Add QUSB2 PHY support for SC7180

From: "Sandeep Maheswaram (Temp)" <sanm@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Boyd <swboyd@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 0/8] Add QUSB2 PHY support for SC7180
Date: Fri, 6 Mar 2020 16:51:35 +0530	[thread overview]
Message-ID: <4fe18d8b-7479-7d1c-ccbe-9d9404b60ba6@codeaurora.org> (raw)
In-Reply-To: <20200305185132.GT24720@google.com>

Hi Matthias,

Will do it by 3/9.

Regards

Sandeep

On 3/6/2020 12:21 AM, Matthias Kaehlcke wrote:
> On Mon, Feb 03, 2020 at 10:56:49AM -0800, Bjorn Andersson wrote:
>> On Wed 29 Jan 05:51 PST 2020, Sandeep Maheswaram wrote:
>>
>> Kishon, afaict this is all reviewed, let me know when you're taking the
>> phy pieces and I'll pick up the dts changes.
> The series has a few minor comments. Sandeep, could you respin the
> series so that it can be landed?
>
> Thanks
>
> Matthias
>
>>> Converting dt binding to yaml.
>>> Adding compatible for SC7180 in dt bindings.
>>> Added generic QUSB2 V2 PHY support and using the same SC7180 and SDM845.
>>>
>>> Changes in v4:
>>> *Addressed Rob Herrings comments in dt bindings.
>>> *Added new structure for all the overriding tuning params.
>>> *Removed the sc7180 and sdm845 compatible from driver and added qusb2 v2 phy.
>>> *Added the qusb2 v2 phy compatible in device tree for sc7180 and sdm845.
>>>
>>> Changes in v3:
>>> *Using the generic phy cfg table for QUSB2 V2 phy.
>>> *Added support for overriding tuning parameters in QUSB2 V2 PHY
>>> from device tree.
>>>
>>> Changes in v2:
>>> Sorted the compatible in driver.
>>> Converted dt binding to yaml.
>>> Added compatible in yaml.
>>>
>>> Sandeep Maheswaram (8):
>>>    dt-bindings: phy: qcom,qusb2: Convert QUSB2 phy bindings to yaml
>>>    dt-bindings: phy: qcom,qusb2: Add compatibles for QUSB2 V2 phy and
>>>      SC7180
>>>    phy: qcom-qusb2: Add generic QUSB2 V2 PHY support
>>>    dt-bindings: phy: qcom-qusb2: Add support for overriding Phy tuning
>>>      parameters
>>>    phy: qcom-qusb2: Add support for overriding tuning parameters in QUSB2
>>>      V2 PHY
>>>    arm64: dts: qcom: sc7180: Add generic QUSB2 V2 Phy compatible
>>>    arm64: dts: qcom: sdm845: Add generic QUSB2 V2 Phy compatible
>>>    arm64: dts: qcom: sc7180: Update QUSB2 V2 Phy params for SC7180 IDP
>>>      device
>>>
>>>   .../devicetree/bindings/phy/qcom,qusb2-phy.yaml    | 182 +++++++++++++++++++++
>>>   .../devicetree/bindings/phy/qcom-qusb2-phy.txt     |  68 --------
>>>   arch/arm64/boot/dts/qcom/sc7180-idp.dts            |   6 +-
>>>   arch/arm64/boot/dts/qcom/sc7180.dtsi               |   2 +-
>>>   arch/arm64/boot/dts/qcom/sdm845.dtsi               |   4 +-
>>>   drivers/phy/qualcomm/phy-qcom-qusb2.c              | 143 +++++++++++-----
>>>   6 files changed, 291 insertions(+), 114 deletions(-)
>>>   create mode 100644 Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
>>>   delete mode 100644 Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
>>>
>>> -- 
>>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
>>> of Code Aurora Forum, hosted by The Linux Foundation
>>>
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation