From: Thomas Pfaff <tpfaff@pcs.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] tty: Remove pointless synchronize_irq() in uart_port_shutdown()
Date: Tue, 10 May 2022 15:54:00 +0200 [thread overview]
Message-ID: <4fe2d4a1-fc6a-c7fa-d884-5ebd01bebd3@pcs.com> (raw)
From: Thomas Pfaff <tpfaff@pcs.com>
Calling synchronize_irq() after free_irq() is pointless, the context to
the irq is already lost.
It was noticed while creating the bugfix "genirq: Synchronize interrupt
thread startup".
Signed-off-by: Thomas Pfaff <tpfaff@pcs.com>
---
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 57840cf90388..b76e76e650ba 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1704,12 +1704,6 @@ static void uart_port_shutdown(struct tty_port *port)
*/
if (uport)
uport->ops->shutdown(uport);
-
- /*
- * Ensure that the IRQ handler isn't running on another CPU.
- */
- if (uport)
- synchronize_irq(uport->irq);
}
static int uart_carrier_raised(struct tty_port *port)
next reply other threads:[~2022-05-10 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 13:54 Thomas Pfaff [this message]
2022-05-10 17:44 ` [PATCH] tty: Remove pointless synchronize_irq() in uart_port_shutdown() Thomas Gleixner
2022-05-11 6:21 ` Jiri Slaby
2022-05-11 7:48 ` Thomas Pfaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe2d4a1-fc6a-c7fa-d884-5ebd01bebd3@pcs.com \
--to=tpfaff@pcs.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).