From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041Ab2GRCI3 (ORCPT ); Tue, 17 Jul 2012 22:08:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4760 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989Ab2GRCIY (ORCPT ); Tue, 17 Jul 2012 22:08:24 -0400 Message-ID: <50061AD3.6030704@redhat.com> Date: Wed, 18 Jul 2012 10:09:23 +0800 From: Asias He User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: linux-kernel@vger.kernel.org, Alexander Viro , Benjamin LaHaise , James Bottomley , Jeff Moyer , kvm@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, target-devel , linux-scsi , lf-virt , Stefan Hajnoczi , Zhi Yong Wu , Anthony Liguori , Paolo Bonzini , Christoph Hellwig , Jens Axboe , Hannes Reinecke Subject: Re: [PATCH RESEND 0/5] Add vhost-blk support References: <1342169711-12386-1-git-send-email-asias@redhat.com> <20120717150928.GB11587@redhat.com> In-Reply-To: <20120717150928.GB11587@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/17/2012 11:09 PM, Michael S. Tsirkin wrote: > On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: >> >> Hi folks, >> >> [I am resending to fix the broken thread in the previous one.] >> >> This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk >> device accelerator. Compared to userspace virtio-blk implementation, vhost-blk >> gives about 5% to 15% performance improvement. > > Same thing as tcm_host comment: > > It seems not 100% clear whether this driver will have major > userspace using it. And if not, it would be very hard to support a > driver when recent userspace does not use it in the end. > > I think a good idea for 3.6 would be to make it depend on > CONFIG_STAGING. Then we don't commit to an ABI. For this, you can add > a separate Kconfig and source it from drivers/staging/Kconfig. Maybe it > needs to be in a separate directory drivers/vhost/staging/Kconfig. OK. > I Cc'd the list of tcm_host in the hope that you can cooperate on this. Sure. -- Asias