From: Stefan Wahren <wahrenst@gmx.net>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Andrew Murray <andrew.murray@arm.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Eric Anholt <eric@anholt.net>
Cc: f.fainelli@gmail.com, phil@raspberrypi.org,
linux-kernel@vger.kernel.org, mbrugger@suse.com,
james.quinlan@broadcom.com
Subject: [PATCH 2/4] ARM: dts: bcm2711: Enable PCIe controller
Date: Thu, 7 Nov 2019 18:44:00 +0100 [thread overview]
Message-ID: <50074e33-17bf-d555-cbf6-4ec079472ecd@gmx.net> (raw)
In-Reply-To: <20191106214527.18736-3-nsaenzjulienne@suse.de>
Hi Nicolas,
please move this patch behind the driver patches, which is the better order.
Am 06.11.19 um 22:45 schrieb Nicolas Saenz Julienne:
> This enables bcm2711's PCIe bus, wich is hardwired to a VIA Technologies
> XHCI USB 3.0 controller.
AFAIU this only applies to the Raspberry Pi 4, since the VIA is outside
of the SoC.
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> arch/arm/boot/dts/bcm2711.dtsi | 47 ++++++++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index a9d84e28f245..c7b2e7b57da6 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -288,6 +288,53 @@
> arm,cpu-registers-not-fw-configured;
> };
>
> + scb {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <1>;
> +
> + ranges = <0x0 0x7c000000 0x0 0xfc000000 0x03800000>,
> + <0x6 0x00000000 0x6 0x00000000 0x40000000>;
> +
> + pcie_0: pcie@7d500000 {
> + compatible = "brcm,bcm2711-pcie";
> + reg = <0x0 0x7d500000 0x9310>;
> + msi-controller;
> + msi-parent = <&pcie_0>;
> + #address-cells = <3>;
> + #interrupt-cells = <1>;
> + #size-cells = <2>;
> + linux,pci-domain = <0>;
> + brcm,enable-ssc;
> + interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "pcie", "msi";
> + interrupt-map-mask = <0x0 0x0 0x0 0x7>;
> + interrupt-map = <0 0 0 1 &gicv2 GIC_SPI 143
> + IRQ_TYPE_LEVEL_HIGH
> + 0 0 0 2 &gicv2 GIC_SPI 144
> + IRQ_TYPE_LEVEL_HIGH
> + 0 0 0 3 &gicv2 GIC_SPI 145
> + IRQ_TYPE_LEVEL_HIGH
> + 0 0 0 4 &gicv2 GIC_SPI 146
> + IRQ_TYPE_LEVEL_HIGH>;
> +
> + ranges = <0x02000000 0x0 0xf8000000 0x6 0x00000000
> + 0x0 0x04000000>;
> + /*
> + * The wrapper around the PCIe block has a bug
> + * preventing it from accessing beyond the first 3GB of
> + * memory. As the bus DMA mask is rounded up to the
> + * closest power of two of the dma-range size, we're
> + * forced to set the limit at 2GB. This can be
> + * harmlessly changed in the future once the DMA code
> + * handles non power of two DMA limits.
> + */
> + dma-ranges = <0x02000000 0x0 0x00000000 0x0 0x00000000
> + 0x0 0x80000000>;
In case this bug will ever be fixed, do you see this as a future proof
practical solution?
> + };
> + };
> +
> cpus: cpus {
> #address-cells = <1>;
> #size-cells = <0>;
next prev parent reply other threads:[~2019-11-07 17:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 21:45 [PATCH 0/4] Raspberry Pi 4 PCIe support Nicolas Saenz Julienne
2019-11-06 21:45 ` [PATCH 1/4] dt-bindings: pci: add bindings for brcmstb's PCIe device Nicolas Saenz Julienne
2019-11-07 10:32 ` Andrew Murray
2019-11-07 10:53 ` Nicolas Saenz Julienne
2019-11-13 4:15 ` Rob Herring
2019-11-14 13:15 ` Nicolas Saenz Julienne
2019-11-06 21:45 ` [PATCH 2/4] ARM: dts: bcm2711: Enable PCIe controller Nicolas Saenz Julienne
2019-11-07 10:37 ` Andrew Murray
2019-11-12 9:18 ` Nicolas Saenz Julienne
2019-11-07 17:44 ` Stefan Wahren [this message]
2019-11-07 18:24 ` Nicolas Saenz Julienne
2019-11-06 21:45 ` [PATCH 3/4] PCI: brcmstb: add Broadcom STB PCIe host controller driver Nicolas Saenz Julienne
2019-11-07 15:00 ` Andrew Murray
2019-11-07 16:12 ` Jim Quinlan
2019-11-08 10:52 ` Andrew Murray
2019-11-08 16:33 ` Jim Quinlan
2019-11-07 17:30 ` Nicolas Saenz Julienne
2019-11-08 10:51 ` Andrew Murray
2019-11-07 17:50 ` Stefan Wahren
2019-11-08 11:13 ` Nicolas Saenz Julienne
2019-11-11 7:10 ` Jeremy Linton
2019-11-11 15:29 ` Nicolas Saenz Julienne
2019-11-11 16:40 ` Florian Fainelli
2019-11-11 20:00 ` Jeremy Linton
2019-11-11 21:27 ` Florian Fainelli
2019-11-06 21:45 ` [PATCH 4/4] PCI: brcmstb: add MSI capability Nicolas Saenz Julienne
2019-11-07 15:40 ` Marc Zyngier
2019-11-11 11:21 ` Nicolas Saenz Julienne
2019-11-11 13:29 ` Marc Zyngier
2019-11-06 21:51 ` [PATCH 0/4] Raspberry Pi 4 PCIe support Florian Fainelli
2019-11-07 9:58 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50074e33-17bf-d555-cbf6-4ec079472ecd@gmx.net \
--to=wahrenst@gmx.net \
--cc=andrew.murray@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mbrugger@suse.com \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).