From: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
To: suresh.b.siddha@intel.com
Cc: tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com,
yinghai@kernel.org, agordeev@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org, yrl.pp-manager.tt@hitachi.com
Subject: Re: [PATCH] x86/ioapic: Fix NULL pointer dereference on CPU hotplug after disabling irqs
Date: Thu, 26 Jul 2012 18:38:49 +0900 [thread overview]
Message-ID: <50111029.6040408@hitachi.com> (raw)
In-Reply-To: <BC5CD145C5D9E74D86490E60F52766FF1EBCFCDD@ORSMSX105.amr.corp.intel.com>
Hi, thanks for your comment.
On 2012/07/26 8:28, Siddha, Suresh B wrote:
> Tomoki wrote:
>> In current Linux, percpu variable `vector_irq' is not always cleared when
>> a CPU is offlined. If the cpu that has the disabled irqs in vector_irq is
>> hotplugged again, __setup_vector_irq() hits invalid irq vector and may
>> crash.
>>
>> Commit f6175f5bfb4c partially fixes this, but was not enough in
>> environments with IOMMU IRQ remapper.
>
> So, this patch essentially makes the commit f6175f5bfb4c unnecessary, right?
>
> Can you revert that too as part of this new proposed patch?
>
> thanks,
> suresh
OK, I will include a reverse patch of f6175f5bfb4c and resend the patch.
Thanks,
--
Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
next prev parent reply other threads:[~2012-07-26 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 9:17 [PATCH] x86/ioapic: Fix NULL pointer dereference on CPU hotplug after disabling irqs Tomoki Sekiyama
2012-07-25 23:28 ` Siddha, Suresh B
2012-07-26 9:38 ` Tomoki Sekiyama [this message]
2012-07-26 9:43 ` Tomoki Sekiyama
2012-07-26 10:21 ` Ingo Molnar
2012-07-26 10:47 ` [RESEND PATCH] " Tomoki Sekiyama
2012-07-26 15:16 ` [tip:x86/urgent] " tip-bot for Tomoki Sekiyama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50111029.6040408@hitachi.com \
--to=tomoki.sekiyama.qu@hitachi.com \
--cc=agordeev@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).