From: Sasha Levin <levinsasha928@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, paul.gortmaker@windriver.com,
davem@davemloft.net, rostedt@goodmis.org, mingo@elte.hu,
ebiederm@xmission.com, aarcange@redhat.com, ericvh@gmail.com,
netdev@vger.kernel.org
Subject: Re: [RFC v2 1/7] hashtable: introduce a small and naive hashtable
Date: Sat, 04 Aug 2012 02:03:14 +0200 [thread overview]
Message-ID: <501C66C2.2020706@gmail.com> (raw)
In-Reply-To: <CA+55aFwTa_kYgmFwoWa6hwAAM6=2xTgQQf-vEx_gCzpEMnxodQ@mail.gmail.com>
Hi Linus,
On 08/04/2012 01:47 AM, Linus Torvalds wrote:
> Or maybe it's just a gcc bug. I do think this all is way hackier than
> Sasha's original simple code that didn't need these kinds of games,
> and didn't need a size member at all.
>
> I really think all the extra complexity and overhead is just *bad*.
> The first simple version was much nicer and likely generated better
> code too.
The problem with that code was that it doesn't work with dynamically allocated hashtables, or hashtables that grow/shrink.
The alternative to going down this path, is going back to the old code and saying that it only works for the simple case, and if you're interested in something more complex it should have it's own different implementation.
Does it make sense? We'll keep the simple & common case simple, and let anyone who needs something more complex than this write it as an extension?
next prev parent reply other threads:[~2012-08-04 0:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 14:23 [RFC v2 0/7] generic hashtable implementation Sasha Levin
2012-08-03 14:23 ` [RFC v2 1/7] hashtable: introduce a small and naive hashtable Sasha Levin
2012-08-03 17:15 ` Tejun Heo
2012-08-03 17:16 ` Tejun Heo
2012-08-03 21:19 ` Sasha Levin
2012-08-03 21:30 ` Tejun Heo
2012-08-03 21:36 ` Sasha Levin
2012-08-03 21:44 ` Tejun Heo
2012-08-03 21:41 ` Sasha Levin
2012-08-03 21:48 ` Tejun Heo
2012-08-03 22:20 ` Sasha Levin
2012-08-03 22:23 ` Tejun Heo
2012-08-03 22:26 ` Sasha Levin
2012-08-03 22:29 ` Linus Torvalds
2012-08-03 22:36 ` Tejun Heo
2012-08-03 23:47 ` Linus Torvalds
2012-08-04 0:03 ` Sasha Levin [this message]
2012-08-04 0:05 ` Linus Torvalds
2012-08-04 0:33 ` Sasha Levin
2012-08-04 0:05 ` Tejun Heo
2012-08-03 17:39 ` Eric Dumazet
2012-08-03 14:23 ` [RFC v2 2/7] user_ns: use new hashtable implementation Sasha Levin
2012-08-05 0:58 ` Eric W. Biederman
2012-08-03 14:23 ` [RFC v2 3/7] mm,ksm: " Sasha Levin
2012-08-03 14:23 ` [RFC v2 4/7] workqueue: " Sasha Levin
2012-08-03 14:23 ` [RFC v2 5/7] mm/huge_memory: " Sasha Levin
2012-08-03 14:23 ` [RFC v2 6/7] tracepoint: " Sasha Levin
2012-08-05 0:36 ` Steven Rostedt
2012-08-05 16:31 ` Mathieu Desnoyers
2012-08-05 17:03 ` Sasha Levin
2012-08-05 17:12 ` Mathieu Desnoyers
2012-08-03 14:23 ` [RFC v2 7/7] net,9p: " Sasha Levin
2012-08-03 18:00 ` Eric Dumazet
2012-08-03 21:14 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501C66C2.2020706@gmail.com \
--to=levinsasha928@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).