From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"thierry.reding@avionic-design.de"
<thierry.reding@avionic-design.de>,
"bfields@redhat.com" <bfields@redhat.com>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
Pavel Emelianov <xemul@parallels.com>,
"neilb@suse.de" <neilb@suse.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"paul.gortmaker@windriver.com" <paul.gortmaker@windriver.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"gorcunov@openvz.org" <gorcunov@openvz.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
"devel@openvz.org" <devel@openvz.org>,
"ebiederm@xmission.com" <ebiederm@xmission.com>
Subject: Re: [RFC PATCH 5/5] syscall: sys_fbind() introduced
Date: Wed, 15 Aug 2012 20:43:49 +0400 [thread overview]
Message-ID: <502BD1C5.6080002@parallels.com> (raw)
In-Reply-To: <502BCEAD.7050905@zytor.com>
15.08.2012 20:30, H. Peter Anvin пишет:
> On 08/15/2012 09:22 AM, Stanislav Kinsbursky wrote:
>> This syscall allows to bind socket to specified file descriptor.
>> Descriptor can be gained by simple open with O_PATH flag.
>> Socket node can be created by sys_mknod().
>>
>> Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
>> ---
>> arch/x86/syscalls/syscall_32.tbl | 1 +
>> arch/x86/syscalls/syscall_64.tbl | 1 +
>> include/linux/syscalls.h | 1 +
>> kernel/sys_ni.c | 3 +++
>> net/socket.c | 25 +++++++++++++++++++++++++
>> 5 files changed, 31 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl
>> index 7a35a6e..9594b82 100644
>> --- a/arch/x86/syscalls/syscall_32.tbl
>> +++ b/arch/x86/syscalls/syscall_32.tbl
>> @@ -356,3 +356,4 @@
>> 347 i386 process_vm_readv sys_process_vm_readv compat_sys_process_vm_readv
>> 348 i386 process_vm_writev sys_process_vm_writev compat_sys_process_vm_writev
>> 349 i386 kcmp sys_kcmp
>> +350 i386 fbind sys_fbind
>
> i386 uses socketcalls... perhaps it shouldn't (socketcalls are pretty
> much an abomination), but for socketcall-based architectures this really
> should be a socketcall.
>
Thanks, Peter. I'll rework this.
> Don't you also need fconnect()? Or is that simply handled by allowing
> open() without O_PATH?
>
Yes, I need it.
If this approach will be accepted, then I'll send one more patch set for fconnect.
> -hpa
>
--
Best regards,
Stanislav Kinsbursky
next prev parent reply other threads:[~2012-08-15 16:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 16:21 [RFC PATCH 0/5] net: socket bind to file descriptor introduced Stanislav Kinsbursky
2012-08-15 16:22 ` [RFC PATCH 1/5] net: cleanup unix_bind() a little Stanislav Kinsbursky
2012-08-15 16:22 ` [RFC PATCH 2/5] net: split unix_bind() Stanislav Kinsbursky
2012-08-15 16:22 ` [RFC PATCH 3/5] net: new protocol operation fbind() introduced Stanislav Kinsbursky
2012-08-15 16:22 ` [RFC PATCH 4/5] net: fbind() for unix sockets protocol operations introduced Stanislav Kinsbursky
2012-08-15 16:22 ` [RFC PATCH 5/5] syscall: sys_fbind() introduced Stanislav Kinsbursky
2012-08-15 16:30 ` H. Peter Anvin
2012-08-15 16:43 ` Stanislav Kinsbursky [this message]
2012-08-15 16:52 ` [RFC PATCH 0/5] net: socket bind to file descriptor introduced Ben Pfaff
2012-08-15 17:54 ` H. Peter Anvin
2012-08-15 19:49 ` Eric W. Biederman
2012-08-15 20:58 ` H. Peter Anvin
2012-08-15 21:25 ` Eric W. Biederman
2012-08-16 3:03 ` Eric W. Biederman
2012-08-16 13:54 ` J. Bruce Fields
2012-08-20 10:18 ` Stanislav Kinsbursky
2012-09-04 19:00 ` J. Bruce Fields
2012-10-05 20:00 ` J. Bruce Fields
2012-10-08 8:37 ` Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502BD1C5.6080002@parallels.com \
--to=skinsbursky@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@redhat.com \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@avionic-design.de \
--cc=tim.c.chen@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).