From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Mel Gorman <mgorman@suse.de>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC 1/2] cma: remove __reclaim_pages
Date: Wed, 15 Aug 2012 14:49:55 -0400 [thread overview]
Message-ID: <502BEF53.80200@redhat.com> (raw)
In-Reply-To: <1344934627-8473-2-git-send-email-minchan@kernel.org>
On 08/14/2012 04:57 AM, Minchan Kim wrote:
> Now cma reclaims too many pages by __reclaim_pages which says
> following as
>
> * Reclaim enough pages to make sure that contiguous allocation
> * will not starve the system.
>
> Starve? What does it starve the system? The function which allocate
> free page for migration target would wake up kswapd and do direct reclaim
> if needed during migration so system doesn't starve.
>
> Let remove __reclaim_pages and related function and fields.
Fair enough.
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Acked-by: Rik van Riel <riel@redhat.com>
next prev parent reply other threads:[~2012-08-15 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 8:57 [RFC 0/2] Reduce alloc_contig_range latency Minchan Kim
2012-08-14 8:57 ` [RFC 1/2] cma: remove __reclaim_pages Minchan Kim
2012-08-15 18:49 ` Rik van Riel [this message]
2012-08-16 13:58 ` Mel Gorman
2012-08-17 1:05 ` Minchan Kim
2012-08-17 14:48 ` Marek Szyprowski
2012-08-14 8:57 ` [RFC 2/2] cma: support MIGRATE_DISCARD Minchan Kim
2012-08-14 14:19 ` Michal Nazarewicz
2012-08-15 23:20 ` Minchan Kim
2012-08-16 13:17 ` Michal Nazarewicz
2012-08-15 18:58 ` Rik van Riel
2012-08-15 23:33 ` Minchan Kim
2012-08-16 0:15 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502BEF53.80200@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).