linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: Let the FT5x06 driver build without debugfs
@ 2012-08-17  0:15 Eric W. Biederman
  2012-08-17  8:09 ` Simon Budig
  0 siblings, 1 reply; 7+ messages in thread
From: Eric W. Biederman @ 2012-08-17  0:15 UTC (permalink / raw)
  To: Simon Budig; +Cc: Henrik Rydberg, Dmitry Torokhov, linux-kernel, linux-input


When testing to make certain my user namespace code works
in various configurations I tripped over the tf5x06.c not
building with debugfs disabled.

drivers/input/touchscreen/edt-ft5x06.c: In function ‘edt_ft5x06_ts_remove’:
drivers/input/touchscreen/edt-ft5x06.c:846:14: error: ‘struct edt_ft5x06_ts_data’ has no member named ‘raw_buffer’

Fix the build by placing an #ifdef around the problem kfree.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
 drivers/input/touchscreen/edt-ft5x06.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 9afc777..bc160b3 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -843,7 +843,9 @@ static int __devexit edt_ft5x06_ts_remove(struct i2c_client *client)
 	if (gpio_is_valid(pdata->reset_pin))
 		gpio_free(pdata->reset_pin);
 
+#if defined(CONFIG_DEBUG_FS)
 	kfree(tsdata->raw_buffer);
+#endif
 	kfree(tsdata);
 
 	return 0;
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-08-30 22:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-17  0:15 [PATCH] Input: Let the FT5x06 driver build without debugfs Eric W. Biederman
2012-08-17  8:09 ` Simon Budig
2012-08-17 19:21   ` Eric W. Biederman
2012-08-20 13:53     ` Guenter Roeck
2012-08-22  5:49       ` Dmitry Torokhov
2012-08-30 22:26         ` David Rientjes
2012-08-30 22:55           ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).