From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753571Ab2HQTIC (ORCPT ); Fri, 17 Aug 2012 15:08:02 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:55104 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036Ab2HQTHx (ORCPT ); Fri, 17 Aug 2012 15:07:53 -0400 Message-ID: <502E9686.1030209@wwwdotorg.org> Date: Fri, 17 Aug 2012 13:07:50 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Laxman Dewangan CC: "khali@linux-fr.org" , "ben-linux@fluff.org" , "w.sang@pengutronix.de" , Stephen Warren , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH] i2c: tegra: dynamically control fast clk References: <1345189711-24104-1-git-send-email-ldewangan@nvidia.com> <502E9051.4090507@wwwdotorg.org> <502E914A.1030906@nvidia.com> In-Reply-To: <502E914A.1030906@nvidia.com> X-Enigmail-Version: 1.5a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2012 12:45 PM, Laxman Dewangan wrote: > On Saturday 18 August 2012 12:11 AM, Stephen Warren wrote: >> On 08/17/2012 01:48 AM, Laxman Dewangan wrote: >>> Tegra I2C driver enables the fast clock during initialization >>> and does not disable till driver removed. >>> Enable this clock before transfer and disable after transfer done. >>> >>> Signed-off-by: Laxman Dewangan >>> --- >>> This patch is on top of the clock chnages which is in Tegra sub >>> system and >>> based on >>> i2c: tegra: I2_M_NOSTART functionality not supported in Tegra20 >>> So recommend to go on tegra sub-system. >> What exactly is this patch based on? I checked out Tegra's >> for-3.7/drivers-i2c, cherry-picked the M_NOSTART patch you mentioned, >> and attempted to apply this patch. It doesn't apply. Same if I don't >> cherry-pick the M_NOSTART patch, and same for next-20120816 with/without >> the M_NOSTART patch. > > Then It seems I need to create the patch again and send it. The > M_NOSTART patch was on tot before clock related change and that is the > reason it is not applying. > Should I re-send these two patches together as 1/2 and 2/2 to maintain > sequence? > I can create based on your clock tree. For any I2C-related changes I take through the Tegra tree, basing them on top of for-3.7/drivers-i2c would be best. Feel free to send both patches together again if that's easiest.