linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: Marina Makienko <makienko@ispras.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Daney <david.daney@cavium.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	"Roy.Li" <rongqing.li@windriver.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	ldv-project@ispras.ru
Subject: Re: [PATCH] staging: octeon: Add prevent NAPI from scheduling
Date: Mon, 20 Aug 2012 09:26:34 -0700	[thread overview]
Message-ID: <5032653A.9090403@gmail.com> (raw)
In-Reply-To: <1345459282-8666-1-git-send-email-makienko@ispras.ru>

On 08/20/2012 03:41 AM, Marina Makienko wrote:
> Code inspection shows that this can
> only be triggered by calling napi_enable() without
> napi_disable().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Marina Makienko <makienko@ispras.ru>
> ---
>   drivers/staging/octeon/ethernet-rx.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
> index 34afc16..db81613 100644
> --- a/drivers/staging/octeon/ethernet-rx.c
> +++ b/drivers/staging/octeon/ethernet-rx.c
> @@ -560,4 +560,5 @@ void cvm_oct_rx_shutdown(void)
>   	/* Shutdown all of the NAPIs */
>   	for_each_possible_cpu(i)
>   		netif_napi_del(&cvm_oct_napi[i].napi);
> +		napi_disable(&cvm_oct_napi[i].napi);


Does the order of netif_napi_del() and napi_disable() matter?  If so, 
does this patch have the correct ordering?

I don't really want to apply the patch until we know the answer to these 
two questions.

David Daney



  reply	other threads:[~2012-08-20 16:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 10:41 [PATCH] staging: octeon: Add prevent NAPI from scheduling Marina Makienko
2012-08-20 16:26 ` David Daney [this message]
2012-08-21  7:48   ` [PATCH] staging: octeon: Add prevent NAPI from scheduling IN-REPLY-TO: Marina Makienko
2012-08-21 11:18   ` Marina Makienko
2012-08-20 17:00 ` [PATCH] staging: octeon: Add prevent NAPI from scheduling Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5032653A.9090403@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=david.daney@cavium.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ldv-project@ispras.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=makienko@ispras.ru \
    --cc=ralf@linux-mips.org \
    --cc=rongqing.li@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).