From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@amd64.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Asit K Mallick <asit.k.mallick@intel.com>,
Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Borislav Petkov <borislav.petkov@amd.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH 00/11] x86/microcode: Early load microcode
Date: Mon, 20 Aug 2012 11:51:14 -0700 [thread overview]
Message-ID: <50328722.9060009@zytor.com> (raw)
In-Reply-To: <20120820153927.GB8623@aftab.osrc.amd.com>
On 08/20/2012 08:39 AM, Borislav Petkov wrote:
> On Sat, Aug 18, 2012 at 01:15:18AM -0700, Fenghua Yu wrote:
>> Documentation/x86/earlyucode.txt | 43 +++
>> arch/x86/Kconfig | 22 ++
>> arch/x86/include/asm/cpio.h | 10 +
>> arch/x86/include/asm/microcode.h | 23 ++
>> arch/x86/include/asm/microcode_intel.h | 103 +++++++
>> arch/x86/kernel/Makefile | 3 +
>> arch/x86/kernel/head64.c | 6 +
>> arch/x86/kernel/head_32.S | 6 +
>> arch/x86/kernel/microcode_core.c | 7 +-
>> arch/x86/kernel/microcode_core_early.c | 74 +++++
>> arch/x86/kernel/microcode_intel.c | 185 +------------
>> arch/x86/kernel/microcode_intel_early.c | 482 +++++++++++++++++++++++++++++++
>> arch/x86/kernel/microcode_intel_lib.c | 163 +++++++++++
>
> One more thing:
>
> This screams for adding a directory called "microcode" in the kernel
> sources and moving all the microcode-related files there. IOW:
>
> arch/x86/kernel/cpu/microcode/core.c
> arch/x86/kernel/cpu/microcode/core_early.c
> arch/x86/kernel/cpu/microcode/intel.c
> arch/x86/kernel/cpu/microcode/amd.c
> ...
>
> And yes, they should be under "cpu" too.
>
Not really, but that isn't even Fenghua's fault.
The cpu directory was originally for cpu detection. The whole kernel/
directory, of course, is a morass that might as well be called "misc".
Some things are legitimately there -- mainly the syscall table and
things that mirror the global kernel/ -- but a ton of stuff doesn't make
any sense there.
Reorganizing the kernel/ directory and promoting cpu up one level would
make that make more sense. The pci and irq code are examples of things
that could use their own directories.
-hpa
next prev parent reply other threads:[~2012-08-20 18:51 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 8:15 [PATCH 00/11] x86/microcode: Early load microcode Fenghua Yu
2012-08-18 8:15 ` [PATCH 01/11] Documentation/x86: " Fenghua Yu
2012-08-20 12:26 ` Borislav Petkov
2012-08-18 8:15 ` [PATCH 02/11] x86/lib/cpio.c: Find cpio data by its file name Fenghua Yu
2012-08-18 22:12 ` Henrique de Moraes Holschuh
2012-08-18 23:23 ` Yu, Fenghua
2012-08-19 4:35 ` Henrique de Moraes Holschuh
2012-08-19 5:15 ` H. Peter Anvin
2012-08-20 13:29 ` Borislav Petkov
2012-08-18 8:15 ` [PATCH 03/11] x86/microcode_intel.h: Define functions and macros for early load ucode Fenghua Yu
2012-08-20 13:47 ` Borislav Petkov
2012-08-18 8:15 ` [PATCH 04/11] x86/microcode_core_early.c: Define interfaces " Fenghua Yu
2012-08-18 22:44 ` Henrique de Moraes Holschuh
2012-08-19 2:38 ` Yu, Fenghua
2012-08-19 4:43 ` Henrique de Moraes Holschuh
2012-08-19 5:24 ` H. Peter Anvin
2012-08-19 16:39 ` Yu, Fenghua
2012-08-20 14:06 ` Borislav Petkov
2012-08-20 20:08 ` H. Peter Anvin
2012-08-20 20:19 ` Borislav Petkov
2012-08-21 20:05 ` Yu, Fenghua
2012-08-21 20:13 ` H. Peter Anvin
2012-08-21 20:48 ` Borislav Petkov
2012-08-21 20:52 ` H. Peter Anvin
2012-08-21 20:52 ` Yu, Fenghua
2012-08-21 20:53 ` H. Peter Anvin
2012-08-21 20:58 ` Yu, Fenghua
2012-08-20 14:04 ` Borislav Petkov
2012-08-18 8:15 ` [PATCH 05/11] x86/microcode_intel_lib.c: Early update ucode on Intel's CPU Fenghua Yu
2012-08-20 15:31 ` Borislav Petkov
2012-08-20 16:24 ` Borislav Petkov
2012-08-18 8:15 ` [PATCH 06/11] x86/microcode_intel_early.c: " Fenghua Yu
2012-08-18 8:15 ` [PATCH 07/11] x86/head_32.S: Early update ucode in 32-bit Fenghua Yu
2012-08-18 8:15 ` [PATCH 08/11] x86/head64.c: Early update ucode in 64-bit Fenghua Yu
2012-08-18 8:15 ` [PATCH 09/11] x86/smpboot.c: Early update ucode on AP Fenghua Yu
2012-08-18 8:15 ` [PATCH 10/11] x86/mm/init.c: Copy ucode from initrd image to memory Fenghua Yu
2012-08-18 8:15 ` [PATCH 11/11] x86/Kconfig: Configurations to enable/disable the feature Fenghua Yu
2012-08-20 21:41 ` Paul Bolle
2012-08-20 15:39 ` [PATCH 00/11] x86/microcode: Early load microcode Borislav Petkov
2012-08-20 15:44 ` Yu, Fenghua
2012-08-20 18:51 ` H. Peter Anvin [this message]
2012-08-20 20:04 ` Borislav Petkov
2012-10-01 16:11 Jamie Gloudon
2012-10-01 16:27 ` Borislav Petkov
2012-10-01 23:37 ` Jamie Gloudon
2012-10-02 4:39 ` Borislav Petkov
2012-10-02 13:11 ` Jamie Gloudon
2012-10-02 13:46 ` Borislav Petkov
2012-10-02 6:06 ` H. Peter Anvin
2012-10-02 19:00 ` Konrad Rzeszutek Wilk
2012-10-02 19:04 ` H. Peter Anvin
2012-10-03 13:13 ` Konrad Rzeszutek Wilk
2012-12-12 17:41 ` H. Peter Anvin
2012-10-02 19:04 ` Yu, Fenghua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50328722.9060009@zytor.com \
--to=hpa@zytor.com \
--cc=andreas.herrmann3@amd.com \
--cc=asit.k.mallick@intel.com \
--cc=borislav.petkov@amd.com \
--cc=bp@amd64.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).