From: "H. Peter Anvin" <hpa@zytor.com>
To: Matt Fleming <matt.fleming@intel.com>
Cc: Olof Johansson <olof@lixom.net>,
Maarten Lankhorst <maarten.lankhorst@canonical.com>,
linux-kernel@vger.kernel.org, mk@dee.su,
Marko Kohtala <marko.kohtala@gmail.com>,
Matthew Garrett <mjg@redhat.com>, Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH] x86: efi: Turn off efi_enabled after setup on mixed fw/kernel
Date: Tue, 21 Aug 2012 07:53:36 -0700 [thread overview]
Message-ID: <5033A0F0.8080705@zytor.com> (raw)
In-Reply-To: <1345559940.3088.56.camel@mfleming-mobl1.ger.corp.intel.com>
On 08/21/2012 07:39 AM, Matt Fleming wrote:
> On Mon, 2012-08-20 at 14:59 -0700, Olof Johansson wrote:
>>> From a quick glance with some grepping, efi reboot and efifb will
>>> also no longer work, is that intentional?
>>
>> That's the very point of this patch, the EFI services won't work since
>> there are no runtime services in this state, just boot time setup. If
>> efi_enabled is left on, the reboot will panic.
>
> But efifb should still work without EFI runtime services, no? I see this
> in setup_arch(),
>
> #ifdef CONFIG_VT
> #if defined(CONFIG_VGA_CONSOLE)
> if (!efi_enabled || (efi_mem_type(0xa0000) != EFI_CONVENTIONAL_MEMORY))
> conswitchp = &vga_con;
> #elif defined(CONFIG_DUMMY_CONSOLE)
> conswitchp = &dummy_con;
> #endif
> #endif
>
> but efi_enabled check looks bogus now that efi_enabled has come to mean
> "EFI services available?". If we've been passed the dimensions of the
> EFI framebuffer I'm unaware of a reason we can't use it.
>
Yes, this should be conditional on the parameters being available.
However, efi_mem_type() is probably also ill-defined in this case.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-08-21 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 21:48 [PATCH] x86: efi: Turn off efi_enabled after setup on mixed fw/kernel Olof Johansson
2012-08-20 9:56 ` Matt Fleming
2012-08-20 10:13 ` Maarten Lankhorst
2012-08-20 21:59 ` Olof Johansson
2012-08-21 14:39 ` Matt Fleming
2012-08-21 14:53 ` H. Peter Anvin [this message]
2012-10-08 14:28 ` Matt Fleming
2012-10-24 6:24 ` [PATCH v2] " Olof Johansson
2012-10-24 8:40 ` Maarten Lankhorst
2012-10-24 15:21 ` Olof Johansson
2012-10-24 15:50 ` Maarten Lankhorst
2012-10-24 17:00 ` [PATCH v3] " Olof Johansson
2012-10-25 10:56 ` Matt Fleming
2012-10-25 13:20 ` Matt Fleming
2012-10-25 17:05 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5033A0F0.8080705@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=marko.kohtala@gmail.com \
--cc=matt.fleming@intel.com \
--cc=mjg@redhat.com \
--cc=mk@dee.su \
--cc=olof@lixom.net \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).