From: Larry Finger <Larry.Finger@lwfinger.net>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
yongjun_wei@trendmicro.com.cn, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl871x_mlme.c: use is_zero_ether_addr() instead of memcmp()
Date: Thu, 23 Aug 2012 10:23:21 -0500 [thread overview]
Message-ID: <50364AE9.7070600@lwfinger.net> (raw)
In-Reply-To: <CAPgLHd-SdeouStUf=2C-cmtn-UC-ckt7CUBfUNZBCHm-vB6=TQ@mail.gmail.com>
On 08/23/2012 02:20 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using is_zero_ether_addr() instead of directly use
> memcmp() to determine if the ethernet address is
> all zeros.
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/staging/rtl8712/rtl871x_mlme.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
The content of this patch is OK, but the subject line needs to be "staging:
r8712u: rtl871x_mlme.c" use ....". Without that "r8712u" addition, searching the
git log for all changes to r8712u is a lot harder.
With that change: ACKED-by: Larry Finger <Larry.Finger@lwfinger.net>
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index dc7adc1..c51ad9e 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -28,6 +28,8 @@
>
> #define _RTL871X_MLME_C_
>
> +#include <linux/etherdevice.h>
> +
> #include "osdep_service.h"
> #include "drv_types.h"
> #include "recv_osdep.h"
> @@ -146,9 +148,8 @@ static struct wlan_network *_r8712_find_network(struct __queue *scanned_queue,
> unsigned long irqL;
> struct list_head *phead, *plist;
> struct wlan_network *pnetwork = NULL;
> - u8 zero_addr[ETH_ALEN] = {0, 0, 0, 0, 0, 0};
>
> - if (!memcmp(zero_addr, addr, ETH_ALEN))
> + if (is_zero_ether_addr(addr))
> return NULL;
> spin_lock_irqsave(&scanned_queue->lock, irqL);
> phead = get_list_head(scanned_queue);
>
>
>
prev parent reply other threads:[~2012-08-23 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 7:20 [PATCH] staging: rtl871x_mlme.c: use is_zero_ether_addr() instead of memcmp() Wei Yongjun
2012-08-23 15:23 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50364AE9.7070600@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).