From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: akhilesh kumar <kumarakhilesh479@gmail.com>
Cc: ananth@in.ibm.com, anil.s.keshavamurthy@intel.com,
davem@davemloft.net, linux-kernel@vger.kernel.org,
yrl.pp-manager.tt@hitachi.com
Subject: Re: [Memory Leak] free kprobe before optimized_kprobe free
Date: Fri, 24 Aug 2012 11:04:42 +0900 [thread overview]
Message-ID: <5036E13A.6070901@hitachi.com> (raw)
In-Reply-To: <CAG6PDMa6OR4eqckoUwuHcv7om2j5qsYx9mPx4_Z+Bzr8nxaMLA@mail.gmail.com>
(2012/08/24 2:05), akhilesh kumar wrote:
> From a77438899c7295299b59cdca8d1816ea69d6ed8e Mon Sep 17 00:00:00 2001
> From: Akhilesh Kumar <akhilesh.lxr@gmail.com>
> Date: Fri, 10 Aug 2012 14:02:07 +0530
> Subject:[Memory Leak] free kprobe before optimized_kprobe free
>
> Free *ap before *op otherwise ap pointer will be Dangling
Nack, since ap == op, this causes double free.
/*
* Internal structure for direct jump optimized probe
*/
struct optimized_kprobe {
struct kprobe kp;
struct list_head list; /* list for optimizing queue */
struct arch_optimized_insn optinsn;
};
Please look into alloc_aggr_kprobe() which allocates
optimized_kprobe, and returns op->kp.
Thank you,
>
> Signed-off-by: Akhilesh Kumar <akhilesh.lxr@gmail.com>
> ---
> kernel/kprobes.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index c62b854..ff0a97b 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -767,6 +767,7 @@ static __kprobes void
> try_to_optimize_kprobe(struct kprobe *p)
> if (!arch_prepared_optinsn(&op->optinsn)) {
> /* If failed to setup optimizing, fallback to kprobe */
> arch_remove_optimized_kprobe(op);
> + kfree(ap);
> kfree(op);
> return;
> }
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2012-08-24 2:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 17:05 [Memory Leak] free kprobe before optimized_kprobe free akhilesh kumar
2012-08-24 2:04 ` Masami Hiramatsu [this message]
2012-08-23 17:10 Akhilesh Kumar
2012-08-23 17:19 ` Rakib Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5036E13A.6070901@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=kumarakhilesh479@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).