From: yalin wang <yalin.wang2010@gmail.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
jmarchan@redhat.com, mgorman@techsingularity.net,
Ebru Akagunduz <ebru.akagunduz@gmail.com>,
willy@linux.intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mm: fix kernel crash in khugepaged thread
Date: Thu, 12 Nov 2015 15:15:01 +0800 [thread overview]
Message-ID: <50393110-D4AD-4FAE-B3A6-63C2DE0730CC@gmail.com> (raw)
In-Reply-To: <20151105085033.GB7614@node.shutemov.name>
Ok
i will send a V3 patch.
> On Nov 5, 2015, at 16:50, Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> On Thu, Nov 05, 2015 at 09:12:34AM +0100, Vlastimil Babka wrote:
>> On 10/29/2015 01:35 AM, Kirill A. Shutemov wrote:
>>>> @@ -2605,9 +2603,9 @@ out_unmap:
>>>> /* collapse_huge_page will return with the mmap_sem released */
>>>> collapse_huge_page(mm, address, hpage, vma, node);
>>>> }
>>>> -out:
>>>> - trace_mm_khugepaged_scan_pmd(mm, page_to_pfn(page), writable, referenced,
>>>> - none_or_zero, result, unmapped);
>>>> + trace_mm_khugepaged_scan_pmd(mm, pte_present(pteval) ?
>>>> + pte_pfn(pteval) : -1, writable, referenced,
>>>> + none_or_zero, result, unmapped);
>>>
>>> maybe passing down pte instead of pfn?
>>
>> Maybe just pass the page, and have tracepoint's fast assign check for !NULL and
>> do page_to_pfn itself? That way the complexity and overhead is only in the
>> tracepoint and when enabled.
>
> Agreed.
>
> --
> Kirill A. Shutemov
prev parent reply other threads:[~2015-11-12 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 10:39 [PATCH V2] mm: fix kernel crash in khugepaged thread yalin wang
2015-10-29 0:35 ` Kirill A. Shutemov
2015-11-05 8:12 ` Vlastimil Babka
2015-11-05 8:50 ` Kirill A. Shutemov
2015-11-12 7:15 ` yalin wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50393110-D4AD-4FAE-B3A6-63C2DE0730CC@gmail.com \
--to=yalin.wang2010@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebru.akagunduz@gmail.com \
--cc=jmarchan@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).