From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925Ab2H1Nej (ORCPT ); Tue, 28 Aug 2012 09:34:39 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:34046 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472Ab2H1Neh (ORCPT ); Tue, 28 Aug 2012 09:34:37 -0400 Message-ID: <503CC904.3050207@gmail.com> Date: Tue, 28 Aug 2012 15:35:00 +0200 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120826 Thunderbird/14.0 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, avi@redhat.com, kvm@vger.kernel.org Subject: Re: [PATCH v2 2/2] virtio-ring: Allocate indirect buffers from cache when possible References: <1346159043-16446-1-git-send-email-levinsasha928@gmail.com> <1346159043-16446-2-git-send-email-levinsasha928@gmail.com> <20120828132032.GB2039@redhat.com> In-Reply-To: <20120828132032.GB2039@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/28/2012 03:20 PM, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 03:04:03PM +0200, Sasha Levin wrote: >> Currently if VIRTIO_RING_F_INDIRECT_DESC is enabled we will >> use indirect descriptors and allocate them using a simple >> kmalloc(). >> >> This patch adds a cache which will allow indirect buffers under >> a configurable size to be allocated from that cache instead. >> >> Signed-off-by: Sasha Levin > > I imagine this helps performance? Any numbers? I ran benchmarks on the original RFC, I've re-tested it now and got similar numbers to the original ones (virtio-net using vhost-net, thresh=16): Before: Recv Send Send Socket Socket Message Elapsed Size Size Size Time Throughput bytes bytes bytes secs. 10^6bits/sec 87380 16384 16384 10.00 4512.12 After: Recv Send Send Socket Socket Message Elapsed Size Size Size Time Throughput bytes bytes bytes secs. 10^6bits/sec 87380 16384 16384 10.00 5399.18 Thanks, Sasha