* [PATCH] staging: ozwpan: remove pointless conditional before kfree_skb()
@ 2012-08-28 13:11 Wei Yongjun
2012-08-28 20:57 ` Rupesh Gujare
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-08-28 13:11 UTC (permalink / raw)
To: rgujare, ckelly, gregkh; +Cc: yongjun_wei, devel, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Remove pointless conditional before kfree_skb().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/staging/ozwpan/ozpd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
index 6c287ac..d515714 100644
--- a/drivers/staging/ozwpan/ozpd.c
+++ b/drivers/staging/ozwpan/ozpd.c
@@ -752,8 +752,7 @@ int oz_isoc_stream_create(struct oz_pd *pd, u8 ep_num)
*/
static void oz_isoc_stream_free(struct oz_isoc_stream *st)
{
- if (st->skb)
- kfree_skb(st->skb);
+ kfree_skb(st->skb);
kfree(st);
}
/*------------------------------------------------------------------------------
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: ozwpan: remove pointless conditional before kfree_skb()
2012-08-28 13:11 [PATCH] staging: ozwpan: remove pointless conditional before kfree_skb() Wei Yongjun
@ 2012-08-28 20:57 ` Rupesh Gujare
0 siblings, 0 replies; 2+ messages in thread
From: Rupesh Gujare @ 2012-08-28 20:57 UTC (permalink / raw)
To: Wei Yongjun; +Cc: ckelly, gregkh, yongjun_wei, devel, linux-kernel
On 28/08/2012 14:11, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Remove pointless conditional before kfree_skb().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/staging/ozwpan/ozpd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
> index 6c287ac..d515714 100644
> --- a/drivers/staging/ozwpan/ozpd.c
> +++ b/drivers/staging/ozwpan/ozpd.c
> @@ -752,8 +752,7 @@ int oz_isoc_stream_create(struct oz_pd *pd, u8 ep_num)
> */
> static void oz_isoc_stream_free(struct oz_isoc_stream *st)
> {
> - if (st->skb)
> - kfree_skb(st->skb);
> + kfree_skb(st->skb);
> kfree(st);
> }
> /*------------------------------------------------------------------------------
>
>
Acked-by: Rupesh Gujare <rgujare@ozmodevices.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-28 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-28 13:11 [PATCH] staging: ozwpan: remove pointless conditional before kfree_skb() Wei Yongjun
2012-08-28 20:57 ` Rupesh Gujare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).