archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <>
To: Jean Delvare <>
Cc: Geert Uytterhoeven <>,,,, Michal Marek <>,,,, Jiri Slaby <>
Subject: Re: i2c-designware-core: KBUILD_MODNAME undeclared [was: Build regressions/improvements in v3.6-rc1]
Date: Fri, 31 Aug 2012 15:18:02 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20120831144429.554345d0@endymion.delvare>

On 08/31/2012 02:44 PM, Jean Delvare wrote:
> Hi Jiri, Geert,
> On Wed, 15 Aug 2012 22:01:38 +0200, Jiri Slaby wrote:
>> On 08/04/2012 11:24 AM, Geert Uytterhoeven wrote:
>>> Below is the list of build error/warning regressions/improvements in
>>> v3.6-rc1[1] compared to v3.5[2].
>> ...
>>>   + drivers/i2c/busses/i2c-designware-core.c: error: 'KBUILD_MODNAME' undeclared (first use in this function):
>> This is a real problem we are facing here. It happens on PPC when all
>> It's because i2c-designware-core.c is used in two modules
>> (i2c-designware-platform and i2c-designware-pci) and KBUILD_MODNAME is
>> not defined for those because (scripts/Makefile.lib):
>> # $(modname_flags) #defines KBUILD_MODNAME as the name of the module
>> # it will end up in (or would, if it gets compiled in)
>> # Note: Files that end up in two or more modules are compiled
>> #       without the KBUILD_MODNAME definition. The reason is
>> #       that any made-up name would differ in different configs.
>> But DYNAMIC_DEBUG needs KBUILD_MODNAME for dev_dbg used in that source.
>> Any ideas? Why is it not a separate module for example?
> It should be. Axel Lin has posted a patch which does that and it should
> fix your problem:
> Please test and confirm it does the right thing. I'll push the patch
> upstream if it does.

Yes, it does.

suse labs

      reply	other threads:[~2012-08-31 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-04  9:24 Build regressions/improvements in v3.6-rc1 Geert Uytterhoeven
2012-08-15 20:01 ` i2c-designware-core: KBUILD_MODNAME undeclared [was: Build regressions/improvements in v3.6-rc1] Jiri Slaby
2012-08-31 12:44   ` Jean Delvare
2012-08-31 13:18     ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: i2c-designware-core: KBUILD_MODNAME undeclared [was: Build regressions/improvements in v3.6-rc1]' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).