linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add mach-specific includes
@ 2012-08-12  9:47 Tzafrir Cohen
  2012-08-31 13:45 ` Michal Marek
  0 siblings, 1 reply; 6+ messages in thread
From: Tzafrir Cohen @ 2012-08-12  9:47 UTC (permalink / raw)
  To: Linux Kbuild; +Cc: Linux Kernel, Tzafrir Cohen

When building a deb package, the linux-headers package should also
add arch/$ARCH/mach-*/include Required for arm and probably some
other architectures: avr32 and blackfin.

This is needed to allow building modules using the headers package.

Signed-off-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
---
 scripts/package/builddeb |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index acb8650..16f8c1a 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -245,6 +245,9 @@ fi
 # Build header package
 (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
 (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
+if echo arch/$SRCARCH/mach-*/include | grep q -v '*'; then
+	(cd $srctree; find arch/$SRCARCH/mach-*/include -type f >> "$objtree/debian/hdrsrcfiles")
+fi
 (cd $objtree; find arch/$SRCARCH/include .config Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
 destdir=$kernel_headers_dir/usr/src/linux-headers-$version
 mkdir -p "$destdir"
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Add mach-specific includes
  2012-08-12  9:47 [PATCH] Add mach-specific includes Tzafrir Cohen
@ 2012-08-31 13:45 ` Michal Marek
  2012-09-05 13:30   ` Tzafrir Cohen
                     ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Michal Marek @ 2012-08-31 13:45 UTC (permalink / raw)
  To: Tzafrir Cohen; +Cc: Linux Kbuild, Linux Kernel, maximilian attems

Adding Max.

On 12.8.2012 11:47, Tzafrir Cohen wrote:
> When building a deb package, the linux-headers package should also
> add arch/$ARCH/mach-*/include Required for arm and probably some
> other architectures: avr32 and blackfin.
> 
> This is needed to allow building modules using the headers package.
> 
> Signed-off-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
> ---
>  scripts/package/builddeb |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index acb8650..16f8c1a 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -245,6 +245,9 @@ fi
>  # Build header package
>  (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
>  (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
> +if echo arch/$SRCARCH/mach-*/include | grep q -v '*'; then

This should probably be grep -q, but it's quite ugly anyway. You can
simply run the find command and redirect it's stderr to /dev/null.

Michal

> +	(cd $srctree; find arch/$SRCARCH/mach-*/include -type f >> "$objtree/debian/hdrsrcfiles")
> +fi
>  (cd $objtree; find arch/$SRCARCH/include .config Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
>  destdir=$kernel_headers_dir/usr/src/linux-headers-$version
>  mkdir -p "$destdir"
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] Add mach-specific includes
  2012-08-31 13:45 ` Michal Marek
@ 2012-09-05 13:30   ` Tzafrir Cohen
  2012-09-05 15:07     ` Maximilian Attems
  2012-09-05 13:33   ` Tzafrir Cohen
  2012-09-09 21:55   ` Jan Engelhardt
  2 siblings, 1 reply; 6+ messages in thread
From: Tzafrir Cohen @ 2012-09-05 13:30 UTC (permalink / raw)
  To: Michal Marek; +Cc: Maximilian Attems, Linux Kbuild, Linux Kernel, Tzafrir Cohen

When building a deb package, the linux-headers package should also
add arch/$ARCH/mach-*/include Required for arm and probably some
other architectures: avr32 and blackfin.

This is needed to allow building modules using the headers package.

Signed-off-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
---
 scripts/package/builddeb |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index acb8650..811a53a 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -245,6 +245,9 @@ fi
 # Build header package
 (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
 (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
+if echo arch/$SRCARCH/mach-*/include | grep -v '*' >/dev/null; then
+	(cd $srctree; find arch/$SRCARCH/mach-*/include -type f >> "$objtree/debian/hdrsrcfiles")
+fi
 (cd $objtree; find arch/$SRCARCH/include .config Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
 destdir=$kernel_headers_dir/usr/src/linux-headers-$version
 mkdir -p "$destdir"
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Add mach-specific includes
  2012-08-31 13:45 ` Michal Marek
  2012-09-05 13:30   ` Tzafrir Cohen
@ 2012-09-05 13:33   ` Tzafrir Cohen
  2012-09-09 21:55   ` Jan Engelhardt
  2 siblings, 0 replies; 6+ messages in thread
From: Tzafrir Cohen @ 2012-09-05 13:33 UTC (permalink / raw)
  To: Michal Marek; +Cc: Linux Kbuild, Linux Kernel, maximilian attems

On Fri, Aug 31, 2012 at 03:45:23PM +0200, Michal Marek wrote:
> 
> On 12.8.2012 11:47, Tzafrir Cohen wrote:

> > +if echo arch/$SRCARCH/mach-*/include | grep q -v '*'; then
> 
> This should probably be grep -q, but it's quite ugly anyway. You can
> simply run the find command and redirect it's stderr to /dev/null.

Redirect its stdout, that is. I'd prefer -q but here's a version with a
redirection.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen@xorcom.com
+972-50-7952406           mailto:tzafrir.cohen@xorcom.com
http://www.xorcom.com  iax:guest@local.xorcom.com/tzafrir

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Add mach-specific includes
  2012-09-05 13:30   ` Tzafrir Cohen
@ 2012-09-05 15:07     ` Maximilian Attems
  0 siblings, 0 replies; 6+ messages in thread
From: Maximilian Attems @ 2012-09-05 15:07 UTC (permalink / raw)
  To: Tzafrir Cohen; +Cc: Michal Marek, Linux Kbuild, Linux Kernel

On Wed, 05 Sep 2012, Tzafrir Cohen wrote:

> When building a deb package, the linux-headers package should also
> add arch/$ARCH/mach-*/include Required for arm and probably some
> other architectures: avr32 and blackfin.
> 
> This is needed to allow building modules using the headers package.
> 
> Signed-off-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
> ---
>  scripts/package/builddeb |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index acb8650..811a53a 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -245,6 +245,9 @@ fi
>  # Build header package
>  (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
>  (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
> +if echo arch/$SRCARCH/mach-*/include | grep -v '*' >/dev/null; then
> +	(cd $srctree; find arch/$SRCARCH/mach-*/include -type f >> "$objtree/debian/hdrsrcfiles")
> +fi
>  (cd $objtree; find arch/$SRCARCH/include .config Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
>  destdir=$kernel_headers_dir/usr/src/linux-headers-$version
>  mkdir -p "$destdir"

no, please redirect find directly to stderr.

thank you.

-- 
maks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Add mach-specific includes
  2012-08-31 13:45 ` Michal Marek
  2012-09-05 13:30   ` Tzafrir Cohen
  2012-09-05 13:33   ` Tzafrir Cohen
@ 2012-09-09 21:55   ` Jan Engelhardt
  2 siblings, 0 replies; 6+ messages in thread
From: Jan Engelhardt @ 2012-09-09 21:55 UTC (permalink / raw)
  To: Michal Marek; +Cc: Tzafrir Cohen, Linux Kbuild, Linux Kernel, maximilian attems


On Friday 2012-08-31 15:45, Michal Marek wrote:
>>  # Build header package
>>  (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
>>  (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
>> +if echo arch/$SRCARCH/mach-*/include | grep q -v '*'; then
>
>This should probably be grep -q, but it's quite ugly anyway.

Use of -q should probably be preferred to >/dev/null,
because with the latter, you will still pay the price
of printf.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-09-09 21:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-12  9:47 [PATCH] Add mach-specific includes Tzafrir Cohen
2012-08-31 13:45 ` Michal Marek
2012-09-05 13:30   ` Tzafrir Cohen
2012-09-05 15:07     ` Maximilian Attems
2012-09-05 13:33   ` Tzafrir Cohen
2012-09-09 21:55   ` Jan Engelhardt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).