From: Lars-Peter Clausen <lars@metafoo.de>
To: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Damien Cassou <damien.cassou@lifl.fr>,
kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] drivers/video/jz4740_fb.c: use devm_ functions
Date: Sun, 02 Sep 2012 17:19:56 +0200 [thread overview]
Message-ID: <5043791C.4050202@metafoo.de> (raw)
In-Reply-To: <5036955F.6000806@gmx.de>
On 08/23/2012 10:41 PM, Florian Tobias Schandinat wrote:
> On 08/03/2012 03:40 PM, Damien Cassou wrote:
>> From: Damien Cassou <damien.cassou@lifl.fr>
>>
>> The various devm_ functions allocate memory that is released when a driver
>> detaches. This patch uses these functions for data that is allocated in the
>> probe function of a platform device and is only freed in the remove function.
>>
>> Signed-off-by: Damien Cassou <damien.cassou@lifl.fr>
>
> Applied.
>
>
> Thanks,
>
> Florian Tobias Schandinat
>
>>
>> ---
>> drivers/video/jz4740_fb.c | 22 ++++++----------------
>> 1 file changed, 6 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/video/jz4740_fb.c b/drivers/video/jz4740_fb.c
>> index de36693..7669770 100644
>> --- a/drivers/video/jz4740_fb.c
>> +++ b/drivers/video/jz4740_fb.c
>> @@ -659,25 +659,25 @@ static int __devinit jzfb_probe(struct platform_device *pdev)
>> jzfb->pdata = pdata;
>> jzfb->mem = mem;
>>
>> - jzfb->ldclk = clk_get(&pdev->dev, "lcd");
>> + jzfb->ldclk = devm_clk_get(&pdev->dev, "lcd");
I guess I'm a bit late, but we do not have devm_clk_get on jz4740 (yet), so
this patch breaks linking for this driver in next. I'll to to have this added
for the next release, but if I do not succeed we'll have to revert part of this
patch.
Also the driver does not include #include <linux/io.h>, since it is required
for devm_ioremap compilation is also broken. This one is easy to fix though,
will send a follow-up patch.
- Lars
next prev parent reply other threads:[~2012-09-02 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 15:40 [PATCH 0/5] use devm_ functions Damien Cassou
2012-08-03 15:40 ` [PATCH 1/5] drivers/video/epson1355fb.c: " Damien Cassou
2012-08-23 20:40 ` Florian Tobias Schandinat
2012-08-03 15:40 ` [PATCH 3/5] drivers/video/jz4740_fb.c: " Damien Cassou
2012-08-23 20:41 ` Florian Tobias Schandinat
2012-09-02 15:19 ` Lars-Peter Clausen [this message]
2012-08-03 15:40 ` [PATCH 2/5] drivers/video/bf54x-lq043fb.c: " Damien Cassou
2012-08-23 20:41 ` Florian Tobias Schandinat
2012-08-03 15:40 ` [PATCH 5/5] drivers/video/msm/mddi_client_nt35399.c: " Damien Cassou
2012-08-06 9:06 ` Dan Carpenter
2012-08-09 17:38 ` David Brown
2012-08-23 20:42 ` Florian Tobias Schandinat
2012-08-03 15:40 ` [PATCH 4/5] drivers/video/msm/mddi_client_dummy.c: " Damien Cassou
2012-08-09 17:39 ` David Brown
2012-08-09 17:57 ` David Brown
2012-08-28 8:42 ` Damien Cassou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5043791C.4050202@metafoo.de \
--to=lars@metafoo.de \
--cc=FlorianSchandinat@gmx.de \
--cc=damien.cassou@lifl.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).