archive mirror
 help / color / mirror / Atom feed
From: Michael Wang <>
To: LKML <>
Cc: Paul Turner <>,
	Dhaval Giani <>,
	Peter Zijlstra <>
Subject: [RFC PATCH 3/4] linsched: avoid invoke tick_nohz_idle_enter() multiple times in idle
Date: Mon, 03 Sep 2012 11:58:10 +0800	[thread overview]
Message-ID: <> (raw)

From: Michael Wang <>

In real world, tick_nohz_idle_enter() will be invoked by idle thread 
when the cpu change from active to idle, and will only be invoked
again after tick_nohz_idle_exit() was invoked by idle thread when
cpu is going to recover, invoke it multiple times in one idle may
cause unexpected troubles.

The patch add a check to avoid invoke tick_nohz_idle_enter() again
after idle.

Signed-off-by: Michael Wang <>
 tools/linsched/hrtimer.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/tools/linsched/hrtimer.c b/tools/linsched/hrtimer.c
index de88b25..3203253 100644
--- a/tools/linsched/hrtimer.c
+++ b/tools/linsched/hrtimer.c
@@ -149,6 +149,15 @@ void linsched_check_idle_cpu(void)
+void linsched_enter_idle(void)
+       int cpu = smp_processor_id();
+       struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
+       if (!ts->inidle && idle_cpu(cpu))
+               tick_nohz_idle_enter();
 /* Run a simulation for some number of ticks. Each tick,
  * scheduling and load balancing decisions are made. Obviously, we
  * could create tasks, change priorities, etc., at certain ticks
@@ -210,7 +219,7 @@ void linsched_run_sim(int sim_ticks)
                        if (idle_cpu(active_cpu) && !need_resched()) {
-                               tick_nohz_idle_enter();
+                               linsched_enter_idle();
                        } else {

                 reply	other threads:[~2012-09-03  3:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).