From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757326Ab2IDOzY (ORCPT ); Tue, 4 Sep 2012 10:55:24 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:12809 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192Ab2IDOzX (ORCPT ); Tue, 4 Sep 2012 10:55:23 -0400 X-IronPort-AV: E=Sophos;i="4.80,367,1344211200"; d="scan'208";a="207015968" Message-ID: <50461654.5040901@citrix.com> Date: Tue, 4 Sep 2012 15:55:16 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120428 Iceowl/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: Stefano Panella , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xensource.com" Subject: Re: [Xen-devel] [PATCH 1/1] XEN: Use correct masking in xen_swiotlb_alloc_coherent. References: <1346407072-6405-1-git-send-email-stefano.panella@citrix.com> <5040B249.4000306@citrix.com> <20120831164010.GA18929@localhost.localdomain> <50460B2E.3020200@citrix.com> <20120904143731.GC23361@phenom.dumpdata.com> In-Reply-To: <20120904143731.GC23361@phenom.dumpdata.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/12 15:37, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 04, 2012 at 03:07:42PM +0100, Stefano Panella wrote: >> >> So if hwdev->coherent_dma_mask is set to 0xffffffffffffffff our dma_mask will >> be u64 set to 0xffffffffffffffff even if we set it to DMA_BIT_MASK(32) previously. > > That is what I was missing. Let me include that in the git commit and also > put this patch on the stable tree. Note that this appears to be a work around for a bug in the sound system or Intel HDA device driver which is incorrectly truncating a dma_addr_t to a u32. So by ensuring a DMA_BIT_MASK(32) when the dma_addr_t is truncated it still works. David