From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757378Ab2IEFyA (ORCPT ); Wed, 5 Sep 2012 01:54:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58251 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755197Ab2IEFx7 (ORCPT ); Wed, 5 Sep 2012 01:53:59 -0400 Message-ID: <5046E8FF.9020504@redhat.com> Date: Wed, 05 Sep 2012 13:54:07 +0800 From: Asias He User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: Rusty Russell , Kent Overstreet , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] virtio-blk: Fix kconfig option References: <20120903044133.GA9980@moria.home.lan> <87wr0ae26e.fsf@rustcorp.com.au> <5046D3A2.3070108@redhat.com> <20120905054830.GB7517@redhat.com> In-Reply-To: <20120905054830.GB7517@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote: > On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote: >> On 09/04/2012 02:23 PM, Rusty Russell wrote: >>> Kent Overstreet writes: >>> >>>> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it >>>> instead. >>> >>> This is a slight mis-understanding. It's supposed to be selected by >>> the particular driver, probably virtio_pci in your case. >> >> virtio_mmio selects virtio as well. >> >> drivers/virtio/Kconfig >> config VIRTIO_MMIO >> select VIRTIO >> config VIRTIO_PCI >> select VIRTIO >> >> How about this: >> config VIRTIO_BLK >> depends on EXPERIMENTAL && (VIRTIO_PCI || VIRTIO_MMIO) > > Isn't this exactly what depends on VIRTIO achieves? Yes. But this gives the information that virtio_blk depends on one of the virtio transport: virito_pci or virtio_mmio. -- Asias