* [PATCH] x86: fix range check in tlbflush debugfs interface
@ 2012-09-07 6:54 Jan Beulich
2012-09-07 9:04 ` [tip:x86/mm] x86/mm: Fix " tip-bot for Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2012-09-07 6:54 UTC (permalink / raw)
To: mingo, tglx, hpa; +Cc: Alex Shi, linux-kernel
Since the shift count settable there is used for shifting values of
type "unsigned long", its value must not match or exceed BITS_PER_LONG
(otherwise the shift operations are undefined). Similarly, the value
must not be negative (but -1 must be permitted, as that's the value
used to distinguish the case of the fine grained flushing being
disabled).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Alex Shi <alex.shi@intel.com>
---
arch/x86/mm/tlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 3.6-rc4/arch/x86/mm/tlb.c
+++ 3.6-rc4-x86-tlb_flushall_shift-limits/arch/x86/mm/tlb.c
@@ -320,7 +320,7 @@ static ssize_t tlbflush_write_file(struc
if (kstrtos8(buf, 0, &shift))
return -EINVAL;
- if (shift > 64)
+ if (shift < -1 || shift >= BITS_PER_LONG)
return -EINVAL;
tlb_flushall_shift = shift;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:x86/mm] x86/mm: Fix range check in tlbflush debugfs interface
2012-09-07 6:54 [PATCH] x86: fix range check in tlbflush debugfs interface Jan Beulich
@ 2012-09-07 9:04 ` tip-bot for Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jan Beulich @ 2012-09-07 9:04 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jbeulich, JBeulich, alex.shi, tglx
Commit-ID: d4c9dbc61fe0ca042b835c6f234af12fa5f18310
Gitweb: http://git.kernel.org/tip/d4c9dbc61fe0ca042b835c6f234af12fa5f18310
Author: Jan Beulich <JBeulich@suse.com>
AuthorDate: Fri, 7 Sep 2012 07:54:52 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 7 Sep 2012 10:56:02 +0200
x86/mm: Fix range check in tlbflush debugfs interface
Since the shift count settable there is used for shifting values
of type "unsigned long", its value must not match or exceed
BITS_PER_LONG (otherwise the shift operations are undefined).
Similarly, the value must not be negative (but -1 must be
permitted, as that's the value used to distinguish the case of
the fine grained flushing being disabled).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Alex Shi <alex.shi@intel.com>
Link: http://lkml.kernel.org/r/5049B65C020000780009990C@nat28.tlf.novell.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/mm/tlb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 613cd83..a085c56 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -320,7 +320,7 @@ static ssize_t tlbflush_write_file(struct file *file,
if (kstrtos8(buf, 0, &shift))
return -EINVAL;
- if (shift > 64)
+ if (shift < -1 || shift >= BITS_PER_LONG)
return -EINVAL;
tlb_flushall_shift = shift;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-07 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-07 6:54 [PATCH] x86: fix range check in tlbflush debugfs interface Jan Beulich
2012-09-07 9:04 ` [tip:x86/mm] x86/mm: Fix " tip-bot for Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).