From: "Suzuki K. Poulose" <suzuki@in.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, mahesh@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] [powerpc] Change memory_limit from phys_addr_t to unsigned long long
Date: Fri, 07 Sep 2012 15:31:21 +0530 [thread overview]
Message-ID: <5049C5F1.3050301@in.ibm.com> (raw)
In-Reply-To: <1346981712.2385.30.camel@pasglop>
On 09/07/2012 07:05 AM, Benjamin Herrenschmidt wrote:
> On Tue, 2012-08-21 at 17:12 +0530, Suzuki K. Poulose wrote:
>> There are some device-tree nodes, whose values are of type phys_addr_t.
>> The phys_addr_t is variable sized based on the CONFIG_PHSY_T_64BIT.
>>
>> Change these to a fixed unsigned long long for consistency.
>>
>> This patch does the change only for memory_limit.
>>
>> The following is a list of such variables which need the change:
>>
>> 1) kernel_end, crashk_size - in arch/powerpc/kernel/machine_kexec.c
>>
>> 2) (struct resource *)crashk_res.start - We could export a local static
>> variable from machine_kexec.c.
>>
>> Changing the above values might break the kexec-tools. So, I will
>> fix kexec-tools first to handle the different sized values and then change
>> the above.
>>
>> Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com>
>> ---
>
> Breaks the build on some configs (with 32-bit phys_addr_t):
Sorry for that.
>
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/prom.c: In function
> 'early_init_devtree':
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/prom.c:664:25: error:
> comparison of distinct pointer types lacks a cast
>
> I'm fixing that myself this time but please be more careful.
Sure. Thanks Ben for fixing that.
Suzuki
next prev parent reply other threads:[~2012-09-07 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 11:42 [PATCH v2 0/2][powerpc] Export memory_limit via device tree Suzuki K. Poulose
2012-08-21 11:42 ` [PATCH v2 1/2] [powerpc] Change memory_limit from phys_addr_t to unsigned long long Suzuki K. Poulose
2012-09-07 1:35 ` Benjamin Herrenschmidt
2012-09-07 10:01 ` Suzuki K. Poulose [this message]
2012-08-21 11:42 ` [PATCH v2 2/2] [powerpc] Export memory limit via device tree Suzuki K. Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5049C5F1.3050301@in.ibm.com \
--to=suzuki@in.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).