[PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes

[PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes

[Wang Sheng-Hui]

The function scans @delaying_queue and stops at the first inode
whose dirtied_when is after *work->older_than_this. So the expired
ones being moved are those before *work->older_than_this. Correct
the comment here.

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
 fs/fs-writeback.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index be3efc4..fd255c0 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -248,7 +248,7 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t)
 }
 
 /*
- * Move expired (dirtied after work->older_than_this) dirty inodes from
+ * Move expired (dirtied before work->older_than_this) dirty inodes from
  * @delaying_queue to @dispatch_queue.
  */
 static int move_expired_inodes(struct list_head *delaying_queue,
-- 
1.7.1

Re: [PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes

[Jan Kara]

On Sat 08-09-12 23:49:00, Wang Sheng-Hui wrote:
> The function scans @delaying_queue and stops at the first inode
> whose dirtied_when is after *work->older_than_this. So the expired
> ones being moved are those before *work->older_than_this. Correct
> the comment here.
  Fengguang Wu would be a more appropriate for this. Added to CC. BTW the
patch is fine so feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
>  fs/fs-writeback.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index be3efc4..fd255c0 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -248,7 +248,7 @@ static bool inode_dirtied_after(struct inode *inode, unsigned long t)
>  }
>  
>  /*
> - * Move expired (dirtied after work->older_than_this) dirty inodes from
> + * Move expired (dirtied before work->older_than_this) dirty inodes from
>   * @delaying_queue to @dispatch_queue.
>   */
>  static int move_expired_inodes(struct list_head *delaying_queue,
> -- 
> 1.7.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: [PATCH] vfs: correct comment for fs/fs-writeback.c/move_expired_inodes

[Fengguang Wu]

On Mon, Sep 10, 2012 at 06:26:33PM +0200, Jan Kara wrote:
> On Sat 08-09-12 23:49:00, Wang Sheng-Hui wrote:
> > The function scans @delaying_queue and stops at the first inode
> > whose dirtied_when is after *work->older_than_this. So the expired
> > ones being moved are those before *work->older_than_this. Correct
> > the comment here.
>   Fengguang Wu would be a more appropriate for this. Added to CC. BTW the
> patch is fine so feel free to add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Applied. Thank you!

Fengguang