From: Avi Kivity <avi@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured
Date: Mon, 10 Sep 2012 11:10:12 +0300 [thread overview]
Message-ID: <504DA064.3070402@redhat.com> (raw)
In-Reply-To: <DE8DF0795D48FD4CA783C40EC82923353235C7@SHSMSX101.ccr.corp.intel.com>
On 09/09/2012 06:10 PM, Liu, Jinsong wrote:
> Avi Kivity wrote:
>> On 09/09/2012 05:54 PM, Liu, Jinsong wrote:
>>>>
>>>> hrtimers is an intrusive feature, I don't think we should
>>>> force-enable it. Please change it to a depends on.
>>>
>>> Hmm, if it changed as
>>> config KVM
>>> depends on HIGH_RES_TIMERS
>>> The item 'Kernel-based Virtual Machine (KVM) support (NEW)' even
>>> didn't appear to user when make menuconfig (when HIGH_RES_TIMERS
>>> disable)
>>>
>>> Is it good? I just have a little concern here:)
>>
>> It's not good, but that's what we have.
>>
>> It's okay to force-enable low-impact features (like preempt notifies).
>>
>> hrimers, on the other hand, change kernel behaviour quite deeply.
>>
>> Maybe over time someone will fix the config tools to unhide features
>> that can be enabled by turning on a dependency.
>
> OK, updated as attached.
Thanks, applied.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2012-09-10 8:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 15:07 [PATCH] KVM: tsc deadline timer works only when hrtimer high resolution configured Liu, Jinsong
2012-09-06 13:58 ` Avi Kivity
2012-09-07 12:07 ` Liu, Jinsong
2012-09-09 14:28 ` Avi Kivity
2012-09-09 14:54 ` Liu, Jinsong
2012-09-09 14:59 ` Avi Kivity
2012-09-09 15:10 ` Liu, Jinsong
2012-09-10 8:10 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DA064.3070402@redhat.com \
--to=avi@redhat.com \
--cc=jinsong.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).