From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: <linux-arm-kernel@lists.infradead.org>,
<linux-i2c@vger.kernel.org>, Wolfram Sang <w.sang@pengutronix.de>
Cc: Nikolaus Voss <n.voss@weinmann.de>,
<linux-kernel@vger.kernel.org>, <ben-linux@fluff.org>,
<balbi@ti.com>, <h.feurstein@gmail.com>, <rmallon@gmail.com>,
<adrian.yanes@aalto.fi>, <ludovic.desroches@atmel.com>,
<carsten.behling@garz-fricke.com>
Subject: Re: [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver
Date: Wed, 12 Sep 2012 09:59:01 +0200 [thread overview]
Message-ID: <505040C5.4090703@atmel.com> (raw)
In-Reply-To: <cover.1346225321.git.n.voss@weinmann.de>
On 08/29/2012 09:28 AM, Nikolaus Voss :
> The old driver has two main deficencies:
> i) No repeated start (Sr) condiction is possible, this makes it unusable
> e.g. for most SMBus transfers.
> ii) I/O was done with polling/busy waiting what caused over-/underruns
> even at light system loads and clock speeds.
>
> The new driver overcomes these deficencies and in addition allows for
> more than one TWI interface.
>
> A remaining limitation is the fact, that only one repeated start is
> possible (two concatenated messages). This limitation is imposed by
> the hardware. However, this should not be a problem as all common
> i2c-client communication does not rely on more than one repeated start.
>
> Changes since v11:
> - corrected wrong id_entry on sam9261 twi gpio pdev
Hi Wolfram,
Despite the patch revision written in the subject, it is actually the
real v12 patch series from Nikolaus.
BTW, I suspect that you were not in copy...
In addition to the "Tested-By" tag by Ludovic, you can add my:
Reviewed-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Nikolaus Voss (4):
> drivers/i2c/busses/i2c-at91.c: remove old polling driver
> Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk
> drivers/i2c/busses/i2c-at91.c: add new driver
> G45 TWI: remove open drain setting for twi function gpios
>
> arch/arm/mach-at91/at91rm9200.c | 1 +
> arch/arm/mach-at91/at91rm9200_devices.c | 9 +
> arch/arm/mach-at91/at91sam9260.c | 1 +
> arch/arm/mach-at91/at91sam9261.c | 1 +
> arch/arm/mach-at91/at91sam9261_devices.c | 9 +
> arch/arm/mach-at91/at91sam9263.c | 1 +
> arch/arm/mach-at91/at91sam9g45.c | 2 +
> arch/arm/mach-at91/at91sam9g45_devices.c | 6 -
> arch/arm/mach-at91/at91sam9rl.c | 2 +
> arch/arm/mach-at91/at91sam9x5.c | 3 +
> arch/arm/mach-at91/include/mach/at91_twi.h | 68 ----
> drivers/i2c/busses/Kconfig | 11 +-
> drivers/i2c/busses/i2c-at91.c | 591 ++++++++++++++++++----------
> 13 files changed, 418 insertions(+), 287 deletions(-)
> delete mode 100644 arch/arm/mach-at91/include/mach/at91_twi.h
>
--
Nicolas Ferre
next prev parent reply other threads:[~2012-09-12 7:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 7:28 [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver Nikolaus Voss
2011-11-08 10:49 ` [PATCH v11 1/4] drivers/i2c/busses/i2c-at91.c: remove old polling driver Nikolaus Voss
2011-11-08 10:49 ` [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver Nikolaus Voss
2011-11-08 11:09 ` [PATCH v11 2/4] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk Nikolaus Voss
2011-11-08 11:11 ` [PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios Nikolaus Voss
2012-09-12 7:59 ` Nicolas Ferre [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-22 6:59 [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver Nikolaus Voss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505040C5.4090703@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=adrian.yanes@aalto.fi \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=carsten.behling@garz-fricke.com \
--cc=h.feurstein@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=n.voss@weinmann.de \
--cc=rmallon@gmail.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).