From: Paolo Bonzini <pbonzini@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Jens Axboe <axboe@kernel.dk>, Ric Wheeler <rwheeler@redhat.com>,
linux-iscsi@vger.kernel.org
Subject: Re: [PATCH 2/3] scsi: create an all-zero filter for scanners
Date: Wed, 12 Sep 2012 14:32:49 +0200 [thread overview]
Message-ID: <505080F1.5090606@redhat.com> (raw)
In-Reply-To: <20120912133613.1255aa52@pyramind.ukuu.org.uk>
Il 12/09/2012 14:36, Alan Cox ha scritto:
>> > switch (sdev->type) {
>> > + case TYPE_SCANNER:
>> > + sdev->request_queue->cmd_filter =
>> > + kzalloc(sizeof(struct blk_cmd_filter), GFP_KERNEL);
>> > + /* fallthrough */
> Is that really desireable in the kzalloc failing case ?
Hmm, there is another kmalloc failure in the series that is worse than
this one, actually.
Paolo
next prev parent reply other threads:[~2012-09-12 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 11:23 [PATCH 0/3] block: add queue-private command filter, editable via sysfs Paolo Bonzini
2012-09-12 11:23 ` [PATCH 1/3] block: add back queue-private command filter Paolo Bonzini
2012-09-12 11:23 ` [PATCH 2/3] scsi: create an all-zero filter for scanners Paolo Bonzini
2012-09-12 12:36 ` Alan Cox
2012-09-12 12:32 ` Paolo Bonzini [this message]
2012-09-12 11:23 ` [PATCH 3/3] block: add back command filter modification via sysfs Paolo Bonzini
2012-09-12 11:25 [PATCH 0/3] block: add queue-private command filter, editable " Paolo Bonzini
2012-09-12 11:25 ` [PATCH 2/3] scsi: create an all-zero filter for scanners Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505080F1.5090606@redhat.com \
--to=pbonzini@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@kernel.dk \
--cc=linux-iscsi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).