From: Tilman Schmidt <tilman@imap.cc>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Hansjoerg Lipp <hjlipp@web.de>,
kernel-janitors@vger.kernel.org,
Karsten Keil <isdn@linux-pingi.de>,
gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree
Date: Thu, 13 Sep 2012 11:52:27 +0200 [thread overview]
Message-ID: <5051ACDB.5030407@imap.cc> (raw)
In-Reply-To: <1347462407-13499-9-git-send-email-peter.senna@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]
Am 12.09.2012 17:06, schrieb Peter Senna Tschudin:
> From: Peter Senna Tschudin <peter.senna@gmail.com>
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
[...]
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Tilman Schmidt <tilman@imap.cc>
> ---
> drivers/isdn/gigaset/common.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
> index aa41485..30a6b17 100644
> --- a/drivers/isdn/gigaset/common.c
> +++ b/drivers/isdn/gigaset/common.c
> @@ -1123,7 +1123,6 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors,
> return drv;
>
> error:
> - kfree(drv->cs);
> kfree(drv);
> return NULL;
> }
This is indeed vestigial code, left in when another error path
that needed it was removed. Though innocuous, it's better to
remove it.
Thanks,
Tilman
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2012-09-13 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 15:06 [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree Peter Senna Tschudin
2012-09-13 8:31 ` David Laight
2012-09-13 9:19 ` Dan Carpenter
2012-09-13 9:27 ` Peter Senna Tschudin
2012-09-13 9:52 ` Tilman Schmidt [this message]
2012-09-13 21:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5051ACDB.5030407@imap.cc \
--to=tilman@imap.cc \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=hjlipp@web.de \
--cc=isdn@linux-pingi.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).