From: Jonathan Cameron <jic23@kernel.org>
To: anish singh <anish198519851985@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
cbou@mail.ru, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] [RFC]power: battery: Generic battery driver using IIO
Date: Thu, 13 Sep 2012 13:26:08 +0100 [thread overview]
Message-ID: <5051D0E0.1020505@kernel.org> (raw)
In-Reply-To: <CAK7N6vpn8NiXaPztWv4uo5hjm44252bxZ-WKZoLaoEQCi6rieA@mail.gmail.com>
>>
> Thanks Lars, all of your comments are valid and I will accordingly update.
> I am waiting for some more review comments if there is any and will send
> the updated code.
Beware of that strategy as I for one am guilty of the old approach of
'oh look someone else has commented, I'll wait for the
next version before taking a look' - particularly when it's a good
reviewer like Lars
next prev parent reply other threads:[~2012-09-13 12:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 15:40 [PATCH] [RFC]power: battery: Generic battery driver using IIO anish kumar
2012-09-11 9:59 ` Lars-Peter Clausen
2012-09-12 8:30 ` anish singh
2012-09-13 12:26 ` Jonathan Cameron [this message]
2012-09-13 12:33 ` anish singh
-- strict thread matches above, loose matches on Subject: below --
2012-09-02 15:39 anish kumar
2012-09-02 16:14 ` Sannu K
2012-09-02 21:34 ` Anton Vorontsov
2012-09-04 15:05 ` anish kumar
2012-09-07 7:52 ` Jonathan Cameron
2012-09-08 7:10 ` anish kumar
2012-09-08 8:34 ` Anton Vorontsov
2012-09-08 10:09 ` Jonathan Cameron
2012-09-09 9:32 ` anish kumar
2012-09-09 9:46 ` Lars-Peter Clausen
2012-09-09 9:59 ` Jonathan Cameron
2012-09-07 8:49 ` Lars-Peter Clausen
2012-09-08 7:30 ` anish kumar
2012-09-08 10:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5051D0E0.1020505@kernel.org \
--to=jic23@kernel.org \
--cc=anish198519851985@gmail.com \
--cc=cbou@mail.ru \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).