From: Daniel Wagner <wagi@monom.org>
To: sedat.dilek@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>,
"David S. Miller" <davem@davemloft.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Gao feng <gaofeng@cn.fujitsu.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Joe Perches <joe@perches.com>,
John Fastabend <john.r.fastabend@intel.com>,
Li Zefan <lizefan@huawei.com>,
Neil Horman <nhorman@tuxdriver.com>,
Rick Jones <rick.jones2@hp.com>,
Stanislav Kinsbursky <skinsbursky@parallels.com>,
Tejun Heo <tj@kernel.org>,
netdev@vger.kernel.org, cgroups@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] cgroup: net_cls: Include missing header with sock_update_classid() definition
Date: Fri, 14 Sep 2012 16:50:18 +0200 [thread overview]
Message-ID: <5053442A.7040801@monom.org> (raw)
In-Reply-To: <CA+icZUUrdGgUM32r88EyRHEb3Q6bULqnk74PikQ8A9q25ZA3NA@mail.gmail.com>
Hi Sedat,
On 14.09.2012 16:43, Sedat Dilek wrote:
> On Fri, Sep 14, 2012 at 4:33 PM, Daniel Wagner <wagi@monom.org> wrote:
>> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>>
>> commit 1f66c0a8833c3974ab6b35edcf4f8585b2f94592
>> Author: Daniel Wagner <daniel.wagner@bmw-carit.de>
>> Date: Wed Sep 12 16:12:01 2012 +0200
>>
>> cgroup: net_cls: Move sock_update_classid() declaration to cls_cgroup.h
>>
>> Claimed that there was only net/socket.c depending on
>> sock_update_class(). That is not true drivers/net/tun.c needs to
>> include the cls_cgroup.h header too.
>>
>> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Cc: Gao feng <gaofeng@cn.fujitsu.com>
>> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
>> Cc: Joe Perches <joe@perches.com>
>> Cc: John Fastabend <john.r.fastabend@intel.com>
>> Cc: Li Zefan <lizefan@huawei.com>
>> Cc: Neil Horman <nhorman@tuxdriver.com>
>> Cc: Rick Jones <rick.jones2@hp.com>
>> Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>
>> Cc: Tejun Heo <tj@kernel.org>
>> Cc: netdev@vger.kernel.org
>> Cc: cgroups@vger.kernel.org
>> ---
>>
>> This version is on top of the latest cgroup for-3.7 branch.
>>
>
> Thanks for the quick fix.
No problem. I am still ashamed not finding it myself.
> Please honour Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>.
Sure, will do next time.
> If this is the fix for the breakage in today's Linux-Next
> (next-20120914), please add a "-next" to the subject next time.
Correct, this one is for linux-next but I got the impression that cgroup
for-3.7 branch was ignored because of this. Therefore I have send two
versions. Hmm, I'll need to check the results of todays next tree.
thanks,
daniel
prev parent reply other threads:[~2012-09-14 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 14:33 [PATCH] Fix for "cgroup: Assign subsystem IDs during compile time" Daniel Wagner
2012-09-14 14:33 ` [PATCH v6] cgroup: net_cls: Move sock_update_classid() declaration to cls_cgroup.h Daniel Wagner
2012-09-14 14:33 ` [PATCH] cgroup: net_cls: Include missing header with sock_update_classid() definition Daniel Wagner
2012-09-14 14:43 ` Sedat Dilek
2012-09-14 14:50 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5053442A.7040801@monom.org \
--to=wagi@monom.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=davem@davemloft.net \
--cc=gaofeng@cn.fujitsu.com \
--cc=jhs@mojatatu.com \
--cc=joe@perches.com \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rick.jones2@hp.com \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=skinsbursky@parallels.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).