From: "Jan Beulich" <JBeulich@suse.com>
To: "Ingo Molnar" <mingo@kernel.org>
Cc: <tglx@linutronix.de>, <torvalds@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: Re: [tip:x86/asm] x86: Prefer TZCNT over BFS
Date: Mon, 17 Sep 2012 11:58:51 +0100 [thread overview]
Message-ID: <50571E8B020000780009BBB2@nat28.tlf.novell.com> (raw)
In-Reply-To: <20120917100046.GA32463@gmail.com>
>>> On 17.09.12 at 12:00, Ingo Molnar <mingo@kernel.org> wrote:
> Linus's suggestion is to introduce CONFIG_X86_TZCNT as an add-on
> patch that cleans up and documents what this is all about.
It wasn't just this he complained about. Plus I don't think the
suggested name fits the current scheme - it would imply the
instruction to be available when set, yet that's explicitly _not_
a requirement. So X86_USE_TZCNT would seem a better fit
to me.
> Would you be willing to do such a patch?
If that was the only change needed, yes (hesitantly, as I
personally don't think introducing Kconfig options that have
only a single usage point is really useful). But the complaint
regarding this also getting enabled for old CPUs (which in
my understanding is the purpose of the GENERIC options)
is something that I wouldn't be willing to address (unless I'm
told these two options have another purpose), and thus I
would expect the resulting patch to still get vetoed by Linus
(which in essence means it would be wasted time to try to
address the other complaint).
Jan
next prev parent reply other threads:[~2012-09-17 10:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 11:24 [PATCH] x86: prefer tzcnt over bsf Jan Beulich
2012-09-14 6:23 ` [tip:x86/asm] x86: Prefer TZCNT over BFS tip-bot for Jan Beulich
2012-09-14 21:14 ` Linus Torvalds
2012-09-14 21:32 ` Borislav Petkov
2012-09-17 7:41 ` Jan Beulich
2012-09-17 10:00 ` Ingo Molnar
2012-09-17 10:58 ` Jan Beulich [this message]
2012-09-17 17:00 ` Linus Torvalds
2012-09-17 17:05 ` H. Peter Anvin
2012-09-17 17:13 ` Linus Torvalds
2012-09-18 6:40 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50571E8B020000780009BBB2@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).