From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757085Ab2IRMBc (ORCPT ); Tue, 18 Sep 2012 08:01:32 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:62179 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755162Ab2IRMBa (ORCPT ); Tue, 18 Sep 2012 08:01:30 -0400 Message-ID: <50586250.4060208@mvista.com> Date: Tue, 18 Sep 2012 16:00:16 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Kevin Daughtridge CC: Jiri Kosina , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usbhid: call report_fixup before comparing descriptors References: <50578272.1020902@kdau.com> In-Reply-To: <50578272.1020902@kdau.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 18-09-2012 0:05, Kevin Daughtridge wrote: > hid_post_reset checks the stored report descriptor against what is currently > returned by the device. An HID driver's report_fixup method may have changed the > stored descriptor, however, creating false positives. These leave some devices > nonfunctional after a resume, with a "reset_resume error 1" reported. This patch > passes the new descriptor to the driver's report_fixup method, if any, before it > is compared to the stored one. > BugLink: http://bugs.launchpad.net/bugs/1049623 > Signed-off-by: Kevin Daughtridge > --- > --- a/drivers/hid/usbhid/hid-core.c 2012-08-20 10:17:09.000000000 -0700 > +++ b/drivers/hid/usbhid/hid-core.c 2012-09-16 18:51:45.381868737 -0700 > @@ -1436,6 +1436,10 @@ static int hid_post_reset(struct usb_int > kfree(rdesc); > return 1; > } > + > + if (hid->driver && hid->driver->report_fixup) > + rdesc = hid->driver->report_fixup(hid, rdesc, &status); > + Your patch is whitespace damaged, i.e. has all tabs replaced by spaces. WBR, Sergei