From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755345Ab2ISJK7 (ORCPT ); Wed, 19 Sep 2012 05:10:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55488 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753398Ab2ISJKz (ORCPT ); Wed, 19 Sep 2012 05:10:55 -0400 Message-ID: <50598C1D.4050206@redhat.com> Date: Wed, 19 Sep 2012 12:10:53 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: Alex Williamson , gleb@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 2/2] kvm: Add resampling irqfds for level triggered interrupts References: <20120918031156.12021.27838.stgit@bling.home> <20120918031626.12021.90083.stgit@bling.home> <50598975.50503@redhat.com> <20120919090845.GA26517@redhat.com> In-Reply-To: <20120919090845.GA26517@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/19/2012 12:08 PM, Michael S. Tsirkin wrote: >> Whoa. Can't we put the resampler entry somewhere we don't need to >> search for it? Like a kvm_kernel_irq_routing_entry, that's indexed by >> gsi already (kvm_irq_routing_table::rt_entries[gsi]). > > I'm not sure why would we bother optimizing this, Not optimizing, simplifying. > but if we do, I guess we could look for the irq notifier > which is already indexed by gsi. It's not, it's looked up in a list. -- error compiling committee.c: too many arguments to function