From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Damien Cassou <damien.cassou@lifl.fr>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: mbxfb: Include linux/io.h instead of asm/io.h
Date: Sun, 23 Sep 2012 19:36:22 +0000 [thread overview]
Message-ID: <505F64B6.9020901@gmx.de> (raw)
In-Reply-To: <1346420343.3107.0.camel@phoenix>
On 08/31/2012 01:39 PM, Axel Lin wrote:
> This fixes below build error:
>
> CC [M] drivers/video/mbx/mbxfb.o
> drivers/video/mbx/mbxfb.c: In function 'mbxfb_probe':
> drivers/video/mbx/mbxfb.c:942:2: error: implicit declaration of function 'devm_ioremap_nocache' [-Werror=implicit-function-declaration]
> drivers/video/mbx/mbxfb.c:942:22: warning: assignment makes pointer from integer without a cast [enabled by default]
> drivers/video/mbx/mbxfb.c:952:21: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied. Thanks for pointing this out and fixing it.
Best regards,
Florian Tobias Schandinat
> ---
> drivers/video/mbx/mbxfb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c
> index 9229acf..6563e50 100644
> --- a/drivers/video/mbx/mbxfb.c
> +++ b/drivers/video/mbx/mbxfb.c
> @@ -26,8 +26,7 @@
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/uaccess.h>
> -
> -#include <asm/io.h>
> +#include <linux/io.h>
>
> #include <video/mbxfb.h>
>
prev parent reply other threads:[~2012-09-23 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 13:39 [PATCH] video: mbxfb: Include linux/io.h instead of asm/io.h Axel Lin
2012-09-23 19:36 ` Florian Tobias Schandinat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505F64B6.9020901@gmx.de \
--to=florianschandinat@gmx.de \
--cc=arnd@arndb.de \
--cc=axel.lin@gmail.com \
--cc=damien.cassou@lifl.fr \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).