From: "Jan Beulich" <JBeulich@suse.com>
To: "Ingo Molnar" <mingo@kernel.org>
Cc: "Ingo Molnar" <mingo@elte.hu>, "Tao Guo" <glorioustao@gmail.com>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
<hpa@zytor.com>
Subject: Re: [PATCH] x86_64: Work around old gas bug
Date: Wed, 26 Sep 2012 12:28:14 +0100 [thread overview]
Message-ID: <506302EE020000780009DF72@nat28.tlf.novell.com> (raw)
In-Reply-To: <20120926111610.GB21143@gmail.com>
>>> On 26.09.12 at 13:16, Ingo Molnar <mingo@kernel.org> wrote:
> * Jan Beulich <JBeulich@suse.com> wrote:
>
>> >>> On 26.09.12 at 10:28, Tao Guo <glorioustao@gmail.com> wrote:
>> > gas in binutils(2.16.91) could not parse parentheses within macro
>> > parameters unless fully parenthesized, and this is a workaround to
>> > make old gas work without generating below errors:
>> > arch/x86/kernel/entry_64.S: Assembler messages:
>> > arch/x86/kernel/entry_64.S:387: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:389: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:390: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:391: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:392: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:393: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:394: Error: too many positional arguments
>> >
>> > Signed-off-by: Tao Guo <glorioustao@gmail.com>
>>
>> This looks okay now to me, but I'm somewhat reluctant to
>> formally ack it given that we know how broken those particular
>> gas versions are.
>
> Well, assuming Tao Guo test-booted a kernel build with this old
> GAS version, we could apply this patch on a best-effort basis -
> the changes don't look particularly ugly. If other, unacceptable
> uglies or fragilities come up then we might balk.
>
> Agreed?
Fine with me.
Jan
next prev parent reply other threads:[~2012-09-26 11:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 8:28 [PATCH] x86_64: Work around old gas bug Tao Guo
2012-09-26 10:17 ` Jan Beulich
2012-09-26 11:16 ` Ingo Molnar
2012-09-26 11:28 ` Jan Beulich [this message]
2012-09-26 13:25 ` Greg KH
2012-09-26 14:29 ` Tao Guo
2012-09-27 4:12 ` Ingo Molnar
2012-09-27 6:09 ` [tip:x86/asm] x86_64: Work around old GAS bug tip-bot for Tao Guo
-- strict thread matches above, loose matches on Subject: below --
2012-09-26 6:15 [PATCH] x86_64: Work around old gas bug Tao Guo
2012-09-26 7:13 ` Jan Beulich
2012-09-26 8:15 ` Tao Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506302EE020000780009DF72@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=glorioustao@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).