From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758722Ab2I1S2H (ORCPT ); Fri, 28 Sep 2012 14:28:07 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:58714 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758672Ab2I1S2F (ORCPT ); Fri, 28 Sep 2012 14:28:05 -0400 Message-ID: <5065EC33.90109@linaro.org> Date: Fri, 28 Sep 2012 12:28:03 -0600 From: Mathieu Poirier User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Anton Vorontsov CC: linux-kernel@vger.kernel.org, dwmw2@infradead.org Subject: Re: [PATCH 30/57] power: ab8500: Flush & sync all works References: <1348589574-25655-1-git-send-email-mathieu.poirier@linaro.org> <1348589574-25655-31-git-send-email-mathieu.poirier@linaro.org> <20120927072358.GL8836@lizard> In-Reply-To: <20120927072358.GL8836@lizard> X-Enigmail-Version: 1.5a1pre Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-09-27 01:23 AM, Anton Vorontsov wrote: > On Tue, Sep 25, 2012 at 10:12:27AM -0600, mathieu.poirier@linaro.org wrote: >> From: Jonas Aaberg >> >> Flush and sync all workqueues at suspend to avoid >> that we suspend in the middle of a work. >> >> Signed-off-by: Jonas Aaberg >> Signed-off-by: Mathieu Poirier >> Reviewed-by: Marcus COOPER >> --- >> drivers/power/ab8500_charger.c | 11 +++++++++++ >> drivers/power/ab8500_fg.c | 5 +++++ >> 2 files changed, 16 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/power/ab8500_charger.c b/drivers/power/ab8500_charger.c >> index ee5ad7b..071c7c2 100644 >> --- a/drivers/power/ab8500_charger.c >> +++ b/drivers/power/ab8500_charger.c >> @@ -2862,6 +2862,17 @@ static int ab8500_charger_suspend(struct platform_device *pdev, >> if (delayed_work_pending(&di->check_hw_failure_work)) >> cancel_delayed_work(&di->check_hw_failure_work); >> >> + flush_delayed_work_sync(&di->attach_work); >> + flush_delayed_work_sync(&di->usb_charger_attached_work); >> + flush_delayed_work_sync(&di->ac_charger_attached_work); >> + flush_delayed_work_sync(&di->check_usbchgnotok_work); >> + flush_delayed_work_sync(&di->check_vbat_work); >> + flush_delayed_work_sync(&di->kick_wd_work); >> + >> + flush_work_sync(&di->usb_link_status_work); >> + flush_work_sync(&di->ac_work); >> + flush_work_sync(&di->detect_usb_type_work); > > I belive each of these have to be added by the patches that add the > appropriate work structs. But really, it's better to avoid these many > delayed work. Agreed - on the flip side they were added over multiple patches spanning many centuries. Tracking all this work down would be impossible as history was re-written many time over. What would you like to see happening here ? > >> return 0; >> } >> #else >> diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c >> index e7a0e1f..0e71e7e 100644 >> --- a/drivers/power/ab8500_fg.c >> +++ b/drivers/power/ab8500_fg.c >> @@ -2626,6 +2626,11 @@ static int ab8500_fg_suspend(struct platform_device *pdev, >> struct ab8500_fg *di = platform_get_drvdata(pdev); >> >> flush_delayed_work_sync(&di->fg_periodic_work); >> + flush_work_sync(&di->fg_work); >> + flush_work_sync(&di->fg_acc_cur_work); >> + flush_delayed_work_sync(&di->fg_reinit_work); >> + flush_delayed_work_sync(&di->fg_low_bat_work); >> + flush_delayed_work_sync(&di->fg_check_hw_failure_work); >> >> /* >> * If the FG is enabled we will disable it before going to suspend >> -- >> 1.7.5.4 >> >>