From: Lauri Hintsala <lauri.hintsala@bluegiga.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: csr: fix coding style
Date: Tue, 16 Oct 2012 10:13:02 +0300 [thread overview]
Message-ID: <507D08FE.4070902@bluegiga.com> (raw)
In-Reply-To: <1350287745-14442-1-git-send-email-sj38.park@gmail.com>
Hi,
On 10/15/2012 10:55 AM, SeongJae Park wrote:
> Fix coding style of csr_framework_ext_types.h
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> drivers/staging/csr/csr_framework_ext_types.h | 33 +++++++++++--------------
> 1 file changed, 15 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/csr/csr_framework_ext_types.h b/drivers/staging/csr/csr_framework_ext_types.h
> index 57194ee..7e9cf8e 100644
> --- a/drivers/staging/csr/csr_framework_ext_types.h
> +++ b/drivers/staging/csr/csr_framework_ext_types.h
> @@ -2,11 +2,11 @@
...
> @@ -24,17 +24,15 @@ extern "C" {
>
> #ifdef __KERNEL__
>
> -struct CsrThread
> -{
> - struct task_struct *thread_task;
> - char name[16];
> +struct CsrThreadi {
I think this extra i letter at the end of CsrThreadi string is typo. Did
you try to compile the driver with your changes?
Best regards,
Lauri Hintsala
> + struct task_struct *thread_task;
> + char name[16];
...
next prev parent reply other threads:[~2012-10-16 7:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 7:55 [PATCH] staging: csr: fix coding style SeongJae Park
2012-10-16 7:13 ` Lauri Hintsala [this message]
2012-10-22 20:56 ` Greg KH
2012-10-23 2:13 ` SeongJae Park
2012-10-23 2:41 ` SeongJae Park
2012-10-23 2:53 ` Greg KH
2012-10-23 3:07 ` SeongJae Park
2012-10-25 6:54 [PATCH] staging: csr: Fix " SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507D08FE.4070902@bluegiga.com \
--to=lauri.hintsala@bluegiga.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).