From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106AbcKHRtM (ORCPT ); Tue, 8 Nov 2016 12:49:12 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:54059 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbcKHRtM (ORCPT ); Tue, 8 Nov 2016 12:49:12 -0500 Subject: Re: [PATCH v3 00/10] Move ARC timer code into drivers/clocksource/ To: Daniel Lezcano References: <1478216015-18931-1-git-send-email-vgupta@synopsys.com> CC: Noam Camus , , , , Newsgroups: gmane.linux.kernel.arc,gmane.linux.kernel From: Vineet Gupta Message-ID: <507dedc9-887e-ddf3-5943-a90887c8e0ec@synopsys.com> Date: Tue, 8 Nov 2016 09:49:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478216015-18931-1-git-send-email-vgupta@synopsys.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.35] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2016 04:33 PM, Vineet Gupta wrote: > Hi, > > This series addresses the long pending move of ARC timer code into > drivers/clocksource/. > > Thx, > -Vineet > > v2 -> v3 > > - Fixed a bunch of typos in changelogs [Daniel] > > - aux.h: stubs for {read,write}_aux_reg() inline functions(vs. macros) > to cleanly avoid warnings in !ARC builds [Daniel] > > - Remove __maybe_used in driver given above [Daniel] > > - Ran checkpatch and fixed some space/tab issues > > v1 -> v2 > > - Now 10 patches instead of 9 to handle BIG ENDIAN in arch agnostic way > > - Moved fix for RTC (v1 2/9) ahead of queue (v2 1/10) to allow for easier > stable backport > > - Folded the Kconfig items for RTC and GFRC into single ARC_TIMERS_64BIT > So no special casing for UP/SMP in Kconfig. > Driver already handles the UP vs. SMP at runtime as needed > > - convert WARN() to pr_warn() [Daniel] > - Use of _BITUL() vs. constant 0x8000_0000 [Daniel] > - changelog spellos: [Daniel] > s/depedency/dependency/ > s/seperate/separate/ > > > v2: http://lists.infradead.org/pipermail/linux-snps-arc/2016-November/001724.html > v1: http://lists.infradead.org/pipermail/linux-snps-arc/2016-October/001676.html > > Vineet Gupta (10): > ARC: timer: rtc: implement read loop in "C" vs. inline asm > ARC: timer: gfrc, rtc: deuglify big endian code > ARC: timer: gfrc, rtc: Read BCR to detect whether hardware exists ... > ARC: timer: gfrc: boot print alongside other timers > ARC: time: move time_init() out of the driver > ARC: timer: Build gfrc, rtc under same option (64-bit timers) > ARC: breakout aux handling into a separate header > ARC: move mcip.h into include/soc and adjust the includes > ARC: breakout timer include code into separate header ... > clocksource: import ARC timer driver > > MAINTAINERS | 1 + > arch/arc/Kconfig | 13 +-- > arch/arc/configs/nsimosci_hs_smp_defconfig | 2 +- > arch/arc/configs/vdk_hs38_smp_defconfig | 2 +- > arch/arc/include/asm/arcregs.h | 94 +--------------- > arch/arc/kernel/Makefile | 2 +- > arch/arc/kernel/mcip.c | 2 +- > arch/arc/kernel/setup.c | 17 ++- > arch/arc/plat-axs10x/axs10x.c | 2 +- > drivers/clocksource/Kconfig | 19 ++++ > drivers/clocksource/Makefile | 1 + > .../time.c => drivers/clocksource/arc_timer.c | 125 +++++++-------------- > include/soc/arc/aux.h | 63 +++++++++++ > {arch/arc/include/asm => include/soc/arc}/mcip.h | 10 +- > include/soc/arc/timers.h | 38 +++++++ > include/soc/nps/common.h | 4 +- > 16 files changed, 191 insertions(+), 204 deletions(-) > rename arch/arc/kernel/time.c => drivers/clocksource/arc_timer.c (72%) > create mode 100644 include/soc/arc/aux.h > rename {arch/arc/include/asm => include/soc/arc}/mcip.h (95%) > create mode 100644 include/soc/arc/timers.h > Gentle ping. @Daniel can we please try to get closure on this sometime this week. I've sent a fixup (patch v4) for the build failure reported by o-dat test robot. Thx, -Vineet